Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of container-selinux required #573

Closed
NicolasT opened this issue Feb 13, 2019 · 1 comment
Closed

New version of container-selinux required #573

NicolasT opened this issue Feb 13, 2019 · 1 comment
Assignees
Labels
kind:bug Something isn't working topic:deployment Bugs in or enhancements to deployment stages

Comments

@NicolasT
Copy link
Contributor

As discussed in #553 (review). The current upstream version of container-selinux, 2.74-1, isn't compatible with containerd. We need 2.77-1 or newer.

The spec-file for this version is in the CentOS Git repository, but no builds seem to be available. However, there's a ScientificLinux build at ftp://ftp.pbone.net/mirror/ftp.scientificlinux.org/linux/scientific/7x/external_products/extras/x86_64/container-selinux-2.77-1.el7_6.noarch.rpm

Would be good to have a script to test containerd functionality, until we have better testing infrastructure in place.

@NicolasT NicolasT added kind:bug Something isn't working topic:deployment Bugs in or enhancements to deployment stages moonshot labels Feb 13, 2019
@NicolasT NicolasT added this to the MetalK8s 2.0.0-alpha1 milestone Feb 13, 2019
@NicolasT NicolasT self-assigned this Feb 13, 2019
NicolasT added a commit that referenced this issue Feb 13, 2019
The default `container-selinux` policies as provided by CentOS (2.74)
are not compatible with `containerd`/`runc` (AVC denials when `runc`
attempts to `setattr` on `fifo_file` resources, see links below).

This PR forces the install of a third-party package (so this introduces
some technical debt...), and includes a simple test-script (to be
invoked manually) to check `containerd` is working correctly.

Fixes: #573
See: containers/podman#1980
See: containers/container-selinux@ae6e25b
NicolasT added a commit that referenced this issue Feb 13, 2019
The default `container-selinux` policies as provided by CentOS (2.74)
are not compatible with `containerd`/`runc` (AVC denials when `runc`
attempts to `setattr` on `fifo_file` resources, see links below).

This PR forces the install of a third-party package (so this introduces
some technical debt...), and includes a simple test-script (to be
invoked manually) to check `containerd` is working correctly.

Fixes: #573
See: containers/podman#1980
See: containers/container-selinux@ae6e25b
sayf-eddine-scality pushed a commit that referenced this issue Feb 14, 2019
The default `container-selinux` policies as provided by CentOS (2.74)
are not compatible with `containerd`/`runc` (AVC denials when `runc`
attempts to `setattr` on `fifo_file` resources, see links below).

This PR forces the install of a third-party package (so this introduces
some technical debt...), and includes a simple test-script (to be
invoked manually) to check `containerd` is working correctly.

Fixes: #573
See: containers/podman#1980
See: containers/container-selinux@ae6e25b
@NicolasT
Copy link
Contributor Author

Closed by #574

NicolasT added a commit that referenced this issue Jul 4, 2019
The upstream CentOS 'extras' repository now ships
`container-selinux-2.99-1.el7_6.noarch` which is sufficiently new enough
(i.e., >= 2.77) for `containerd` to work properly. As a result, we no
longer need the version from ScientificLinux.

Since this was the only package in the `metalk8s-external` repository,
this whole repository and the build infrastructure coming with it is now
gone.

Fixes: #575
See: #575
See: #573
See: #574
NicolasT added a commit that referenced this issue Jul 4, 2019
The upstream CentOS 'extras' repository now ships
`container-selinux-2.99-1.el7_6.noarch` which is sufficiently new enough
(i.e., >= 2.77) for `containerd` to work properly. As a result, we no
longer need the version from ScientificLinux.

Since this was the only package in the `metalk8s-external` repository,
this whole repository and the build infrastructure coming with it is now
gone.

Fixes: #575
See: #575
See: #573
See: #574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working topic:deployment Bugs in or enhancements to deployment stages
Projects
None yet
Development

No branches or pull requests

1 participant