Improvement/arsn 423 bump dependencies

.github/workflows/tests.yaml

@@ -28,11 +28,10 @@ jobs:
       uses: actions/checkout@v4
     - uses: actions/setup-node@v4
       with:
-        node-version: '16'
+        node-version: '22'
         cache: 'yarn'
     - name: install dependencies
       run: yarn install --frozen-lockfile --prefer-offline --network-concurrency 1
-      continue-on-error: true # TODO ARSN-97 Remove it when no errors in TS
     - name: lint yaml
       run: yarn --silent lint_yml
     - name: lint javascript
@@ -63,14 +62,12 @@ jobs:
     - name: Install NodeJS
       uses: actions/setup-node@v4
       with:
-        node-version: '16'
+        node-version: '22'
         cache: yarn
     - name: Install dependencies
       run: yarn install --frozen-lockfile --prefer-offline
-      continue-on-error: true # TODO ARSN-97 Remove it when no errors in TS
     - name: Compile
       run: yarn build
-      continue-on-error: true # TODO ARSN-97 Remove it when no errors in TS
     - name: Upload artifacts
       uses: scality/action-artifacts@v4
       with:

README.md

@@ -1,6 +1,7 @@
 # Arsenal
 
-[![codecov](https://codecov.io/gh/scality/Arsenal/branch/development/8.1/graph/badge.svg?token=X0esXhJSwb)](https://codecov.io/gh/scality/Arsenal)
+[![badgepub]](https://github.com/scality/Arsenal/actions/workflows/tests.yaml)
+[![codecov]](https://codecov.io/gh/scality/Arsenal)
 
 Common utilities for the S3 project components
 
@@ -55,6 +56,14 @@ console.log(errors.AccessDenied);
 
 ```
 
+## Build Status
+
+![badgepub]
+
+## Codecov Status
+
+![codecov]
+
 ## Clustering
 
 The clustering class can be used to set up a cluster of workers. The class will
@@ -145,6 +154,3 @@ used to let the application release its resources, but if timeout occurs
 before the application has finished it's cleanup, a 'SIGKILL' signal is send
 to the process (which results in an immediate termination, and this signal
 can't be caught).
-
-[badgepub]: https://circleci.com/gh/scality/Arsenal.svg?style=svg
-[badgepriv]: http://ci.ironmann.io/gh/scality/Arsenal.svg?style=svg&circle-token=c3d2570682cba6763a97ea0bc87521941413d75c

documentation/BucketInfoModelVersion.md

@@ -257,4 +257,4 @@ this._quotaMax = quotaMax || 0;
 
 ### Usage
 
-Used to store bucket quota
+Used to store bucket quota

eslint.config.mjs

@@ -0,0 +1,35 @@
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+import tseslint from 'typescript-eslint';
+import { includeIgnoreFile } from '@eslint/compat';
+
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const gitignorePath = path.resolve(__dirname, '.gitignore');
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default tseslint.config(
+    ...compat.extends('@scality/scality'),
+    ...tseslint.configs.recommended,
+    includeIgnoreFile(gitignorePath),
+    {
+        rules: {
+            '@typescript-eslint/ban-ts-comment': 'off',
+            '@typescript-eslint/no-require-imports': 'off',
+            '@typescript-eslint/no-explicit-any': 'off',
+            '@typescript-eslint/no-empty-object-type': 'off',
+            'camelcase': 'off',
+            'no-param-reassign': 'off',
+            'new-cap': 'off',
+            'quotes': 'off',
+            '@typescript-eslint/no-unsafe-function-type':'off'
+        }
+    }
+);

index.ts

@@ -6,7 +6,7 @@ import RequestContext, {
     actionWithDataDeletion } from './lib/policyEvaluator/RequestContext';
 import * as requestUtils from './lib/policyEvaluator/requestUtils';
 import * as actionMaps from './lib/policyEvaluator/utils/actionMaps';
-import { validateUserPolicy } from './lib/policy/policyValidator'
+import { validateUserPolicy } from './lib/policy/policyValidator';
 import * as locationConstraints from './lib/patches/locationConstraints';
 import * as userMetadata from './lib/s3middleware/userMetadata';
 import convertToXml from './lib/s3middleware/convertToXml';

lib/Clustering.ts

@@ -265,15 +265,15 @@
             this._workersTimeout[i] = setTimeout(() => {
                 // Kill the worker if the sigterm was ignored or take too long
                 if (worker.process.pid) {
-                  process.kill(worker.process.pid, 'SIGKILL');
+                    process.kill(worker.process.pid, 'SIGKILL');
                 }
             }, this._shutdownTimeout);
             // Send sigterm to the process, allowing to release ressources
             // and save some states
             if (worker.process.pid) {
-              return process.kill(worker.process.pid, 'SIGTERM');
+                return process.kill(worker.process.pid, 'SIGTERM');
             } else {
-              return true;
+                return true;
             }
         });
     }

lib/algos/cache/GapCache.ts

@@ -116,7 +116,7 @@
         maxGapWeight: number
     ): GapCache {
         const gapCache = new GapCache(exposureDelayMs, maxGaps, maxGapWeight);
-        gapCache._exposedGaps = GapSet.createFromArray(gaps, maxGapWeight)
+        gapCache._exposedGaps = GapSet.createFromArray(gaps, maxGapWeight);
         return gapCache;
     }
 

lib/algos/cache/GapSet.ts

@@ -1,8 +1,6 @@
 import assert from 'assert';
 import { OrderedSet } from '@js-sdsl/ordered-set';
 
-import errors from '../../errors';
-
 export type GapSetEntry = {
     firstKey: string,
     lastKey: string,
@@ -40,7 +38,7 @@ export default class GapSet implements GapSetInterface, Iterable<GapSetEntry> {
             [],
             (left: GapSetEntry, right: GapSetEntry) => (
                 left.firstKey < right.firstKey ? -1 :
-                left.firstKey > right.firstKey ? 1 : 0
+                    left.firstKey > right.firstKey ? 1 : 0
             )
         );
         this._maxWeight = maxWeight;
@@ -90,7 +88,7 @@ export default class GapSet implements GapSetInterface, Iterable<GapSetEntry> {
             || curGap.lastKey < firstKey    // previous gap not overlapping
             || (curGap.lastKey === firstKey // previous gap overlapping by one key...
                 && curGap.weight + weight > this._maxWeight) // ...but we can't extend it
-           ) {
+        ) {
             // create a new gap indexed by 'firstKey'
             curGap = { firstKey, lastKey: firstKey, weight: 0 };
             this._gaps.insert(curGap);

lib/algos/list/delimiter.ts

@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line strict
+'use strict';
 
 const Extension = require('./Extension').default;
 const { inc, listingParamsMasterKeysV0ToV1,
@@ -213,7 +213,7 @@ export class Delimiter extends Extension {
      * @param {String} key            - full key starting with commonPrefix
      * @return {Boolean}     - indicates if iteration should continue
      */
-    addCommonPrefix(commonPrefix: string, key: string): void {
+    addCommonPrefix(commonPrefix: string): void {
         // add the new prefix to the list
         this.CommonPrefixes.push(commonPrefix);
         ++this.keys;
@@ -224,7 +224,7 @@ export class Delimiter extends Extension {
         // add the subprefix to the common prefixes if the key has the delimiter
         const commonPrefix = this.getCommonPrefix(key);
         if (commonPrefix) {
-            this.addCommonPrefix(commonPrefix, key);
+            this.addCommonPrefix(commonPrefix);
             return commonPrefix;
         }
         this.addContents(key, value);
@@ -306,9 +306,10 @@ export class Delimiter extends Extension {
 
     skippingBase(): string | undefined {
         switch (this.state.id) {
-        case DelimiterFilterStateId.SkippingPrefix:
+        case DelimiterFilterStateId.SkippingPrefix: {
             const { prefix } = <DelimiterFilterState_SkippingPrefix> this.state;
             return inc(prefix);
+        }
 
         default:
             return SKIP_NONE;

lib/algos/list/delimiterCurrent.ts

@@ -1,5 +1,4 @@
 const { DelimiterMaster } = require('./delimiterMaster');
-const { FILTER_ACCEPT, FILTER_END } = require('./tools');
 
 type ResultObject = {
     Contents: {
@@ -46,7 +45,7 @@ class DelimiterCurrent extends DelimiterMaster {
         if (this.excludedDataStoreName) {
             params.dataStoreName = {
                 ne: this.excludedDataStoreName,
-            }
+            };
         }
 
         return params;

lib/algos/list/delimiterMaster.ts

@@ -10,7 +10,7 @@ import {
 const Version = require('../../versioning/Version').Version;
 const VSConst = require('../../versioning/constants').VersioningConstants;
 const { BucketVersioningKeyFormat } = VSConst;
-const { FILTER_ACCEPT, FILTER_SKIP, FILTER_END, SKIP_NONE, inc } = require('./tools');
+const { FILTER_ACCEPT, FILTER_SKIP, FILTER_END, inc } = require('./tools');
 
 import { GapSetEntry } from '../cache/GapSet';
 import { GapCacheInterface } from '../cache/GapCache';
@@ -492,13 +492,15 @@ export class DelimiterMaster extends Delimiter {
 
     skippingBase(): string | undefined {
         switch (this.state.id) {
-        case DelimiterMasterFilterStateId.SkippingVersionsV0:
+        case DelimiterMasterFilterStateId.SkippingVersionsV0: {
             const { masterKey } = <DelimiterMasterFilterState_SkippingVersionsV0> this.state;
             return masterKey + inc(VID_SEP);
+        }
 
-        case DelimiterMasterFilterStateId.SkippingGapV0:
+        case DelimiterMasterFilterStateId.SkippingGapV0: {
             const { gapCached } = <GapCachingInfo_GapCached> this._gapCaching;
             return gapCached.lastKey;
+        }
 
         default:
             return super.skippingBase();
@@ -598,7 +600,8 @@ export class DelimiterMaster extends Delimiter {
     _cutBuildingGap(): void {
         if (this._gapBuilding.state === GapBuildingState.Building) {
             let gapBuilding = <GapBuildingInfo_Building> this._gapBuilding;
-            let { gapCache, params, gap, gapWeight } = gapBuilding;
+            const { gapCache, gap, gapWeight } = gapBuilding;
+            let params = gapBuilding.params;
             // only set gaps that are significant enough in weight and
             // with a non-empty extension
             if (gapWeight >= params.minGapWeight && gap.weight > 0) {

lib/algos/list/delimiterVersions.ts

@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line strict
+'use strict';  
 
 const Extension = require('./Extension').default;
 
@@ -239,7 +239,7 @@ export class DelimiterVersions extends Extension {
             return { key: fullKey };
         }
         const nonversionedKey: string = fullKey.slice(0, versionIdIndex);
-        let versionId: string = fullKey.slice(versionIdIndex + 1);
+        const versionId: string = fullKey.slice(versionIdIndex + 1);
         return { key: nonversionedKey, versionId };
     }
 
@@ -455,16 +455,18 @@ export class DelimiterVersions extends Extension {
 
     skippingBase(): string | undefined {
         switch (this.state.id) {
-        case DelimiterVersionsFilterStateId.SkippingPrefix:
+        case DelimiterVersionsFilterStateId.SkippingPrefix: {
             const { prefix } = <DelimiterVersionsFilterState_SkippingPrefix> this.state;
             return inc(prefix);
+        }
 
-        case DelimiterVersionsFilterStateId.SkippingVersions:
+        case DelimiterVersionsFilterStateId.SkippingVersions: {
             const { gt } = <DelimiterVersionsFilterState_SkippingVersions> this.state;
             // the contract of skipping() is to return the first key
             // that can be skipped to, so adding a null byte to skip
             // over the existing versioned key set in 'gt'
             return `${gt}\0`;
+        }
 
         default:
             return SKIP_NONE;

lib/auth/Vault.ts

@@ -37,9 +37,8 @@ function vaultSignatureCb(
             { errorMessage: err });
         return callback(err);
     }
-
-    const { email, ...userInfoWithoutEmail } = authInfo.message.body.userInfo;
-
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    const { email: _, ...userInfoWithoutEmail } = authInfo.message.body.userInfo;
     log.debug('received info from Vault', {
         ...authInfo,
         message: {
@@ -267,7 +266,7 @@ export default class Vault {
                     foundIds.push({
                         email: key,
                         canonicalID: infoFromVault[key],
-                    })
+                    });
                 }
                 return callback(null, foundIds);
             });

lib/auth/auth.ts

@@ -130,10 +130,10 @@
         return cb(null, res.params);
     }
     if (requestContexts) {
-        requestContexts.forEach((requestContext) => {
-            const { params } = res
+        requestContexts.forEach(requestContext => {
+            const { params } = res;
             if ('data' in params) {
-                const { data } = params
+                const { data } = params;
                 requestContext.setAuthType(data.authType);
                 requestContext.setSignatureVersion(data.signatureVersion);
                 requestContext.setSecurityToken(data.securityToken);
@@ -254,12 +254,12 @@
     Object.assign(request, { headers: {} });
 }
 
-export const server = { extractParams, doAuth }
-export const client = { generateV4Headers, constructStringToSignV2 }
-export const inMemory = { backend: inMemoryBackend, validateAuthConfig, AuthLoader }
-export const backends = { baseBackend, chainBackend }
+export const server = { extractParams, doAuth };
+export const client = { generateV4Headers, constructStringToSignV2 };
+export const inMemory = { backend: inMemoryBackend, validateAuthConfig, AuthLoader };
+export const backends = { baseBackend, chainBackend };
 export {
     setAuthHandler as setHandler,
     AuthInfo,
     Vault
-}
+};