-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/arsn 423 bump dependencies #2266
base: development/8.2
Are you sure you want to change the base?
Improvement/arsn 423 bump dependencies #2266
Conversation
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/improvement/ARSN-423-bump-dependencies && \
git merge origin/development/8.2 Resolve merge conflicts and commit git push origin HEAD:improvement/ARSN-423-bump-dependencies |
57632be
to
7cfe8b2
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development/8.2 #2266 +/- ##
===================================================
+ Coverage 66.45% 66.74% +0.29%
===================================================
Files 216 216
Lines 17443 17452 +9
Branches 3570 3619 +49
===================================================
+ Hits 11591 11649 +58
+ Misses 5836 5799 -37
+ Partials 16 4 -12 ☔ View full report in Codecov by Sentry. |
75aab28
to
751140a
Compare
@@ -279,9 +277,9 @@ export function convertConditionOperator(operator: string): boolean { | |||
} else { | |||
return policyValRegex(key); | |||
} | |||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should return undefined here, because if we reach this stage, it means the "key" was an array and a prefix that is unknown...
07d79a7
to
cb09de6
Compare
50b1389
to
c175969
Compare
b67e160
to
9cc8a28
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
/approve |
/wait |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: approve |
19e6264
to
9eafa33
Compare
9eafa33
to
ba7ade2
Compare
5722c3a
to
33e77f0
Compare
Issue: ARSN-423
In this commit the code has been updated to match the new uuid require based on the documentation here : https://www.npmjs.com/package/uuid timestamp format has been updated as well from new Timestamp(1, 1651144629) to new Timestamp({ t: 1651144629 , i: 1 }), the remaining changes are lint fixups ( please note that the indentation has been fixed as well automatically using lint --fix) Issue: ARSN-423
In this commit we fix the tests that were failing after the dependencies bumps. Issue: ARSN-423
Issue: ARSN-423
33e77f0
to
59f54bb
Compare
8a3abe6
to
a3343a4
Compare
2e1fddb
to
35d1bd8
Compare
244b050
to
2f3c20d
Compare
Issue : ARSN-423