RedundantSyntax: distinguish single and triple quotes

[bjaglin]

🤯

Welcome to Scala 2.13.11 (OpenJDK 64-Bit Server VM, Java 17.0.7).
Type in expressions for evaluation. Or try :help.

scala> s""" \n """ == """ \n """ 
val res0: Boolean = false

scala> s" \n " == " \n "
val res1: Boolean = true

scala> f""" \n """ == """ \n """
val res2: Boolean = false

scala> f" \n " == " \n "
val res3: Boolean = true

scala> raw""" \n """ == """ \n """
val res4: Boolean = true

scala> raw" \n " == " \n "
val res5: Boolean = false

Test input/output had to be duplicated because 2.12 does not support s"my \"quoted\" string"

[bjaglin]

Thanks for the report @bmarker, this was a "fun" fix to make!

[bjaglin]

Oh, it's even "funnier" than I thought, it works in 2.13, but the compiler (or scalameta?) has a different output of string interpolation in 2.12 & 3 so we need a better heuristic than syntax.contains("\"\"\"") to capture usage of """ with scalameta...

Also, it seems that scala/scala#8830 was not backported to 2.12, so we can't use the same test input across versions.

[bjaglin]

this makes sure we still remove the interpolator when we can

[bjaglin]

this makes sure we still remove the interpolator when we can

[bjaglin]

this makes sure we still remove the interpolator when we can

[bjaglin]

this tests the actual fix for the reported problem

[bjaglin]

cc @gontard as the original rule author for visibility

[gontard]

👋 Thanks for the fix!