Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedundantSyntax changed the resulting string value #1849

Closed
bmarker opened this issue Aug 24, 2023 · 1 comment · Fixed by #1851
Closed

RedundantSyntax changed the resulting string value #1849

bmarker opened this issue Aug 24, 2023 · 1 comment · Fixed by #1851

Comments

@bmarker
Copy link

bmarker commented Aug 24, 2023 •
edited
Loading

https://scalacenter.github.io/scalafix/docs/rules/RedundantSyntax.html

Given a string like:

s"""my \"quoted\" string"""

The RedundantSyntax rule removed the s and not the \. This results in: my \"quoted\" string

Where the original value was: my "quoted" string

It seems to me like it should not remove the s in this case. The manual fix is probably to remove the s and unescape the string but that seems like it might be riskier to auto-fix.
@bmarker
Copy link
Author

bmarker commented Aug 24, 2023

ScalaFix 0.11.0 with Scala 2.12.17.

@bjaglin bjaglin linked a pull request Aug 27, 2023 that will close this issue
RedundantSyntax: distinguish single and triple quotes #1851
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RedundantSyntax: distinguish single and triple quotes bjaglin/scalafix
1 participant
@bmarker