Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(type_page): Split 2 variables env #69

Merged
merged 1 commit into from
Oct 1, 2021
Merged

test(type_page): Split 2 variables env #69

merged 1 commit into from
Oct 1, 2021

Conversation

sbecker59
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #69 (3b20bd5) into main (a7a2ae8) will decrease coverage by 0.20%.
The diff coverage is 79.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   82.31%   82.10%   -0.21%     
==========================================
  Files          14       16       +2     
  Lines        1238     1436     +198     
==========================================
+ Hits         1019     1179     +160     
- Misses        156      185      +29     
- Partials       63       72       +9     
Impacted Files Coverage Δ
statuspage/resource_page_access_user.go 73.52% <73.52%> (ø)
statuspage/filter.go 75.71% <75.71%> (ø)
statuspage/resource_page_access_group.go 83.87% <83.87%> (ø)
statuspage/helpers.go 100.00% <100.00%> (ø)
statuspage/provider.go 90.16% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c6f28...3b20bd5. Read the comment docs.

@sbecker59
Copy link
Owner Author

sbecker59 commented Oct 1, 2021

Hi @grierj
Just for information

I created this PR to run the tests. Continuation of PR (#66, #68) .
I added a variable STATUSPAGE_AUDIENCE_SPECIFIC_PAGE_ID in order to be able to play the 2 new resources on a specific audience type statuspage.

I realized with the codecov report that the tests on the import part were missing. #70

I merge this PR, and create a new release

@sbecker59 sbecker59 marked this pull request as ready for review October 1, 2021 18:54
@sbecker59 sbecker59 merged commit 7888cde into main Oct 1, 2021
@sbecker59 sbecker59 deleted the feat/type_page branch October 1, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant