Adding page access group and page access user #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need these for audience manipulation. Trying to follow the standard patterns established here. Updated to the latest client version to pick up all the page access user endpoints and api fixes Full acceptance tests appear to be working ``` $ go test -v -run TestAccStatuspagePageAccessUser_Basic ./statuspage === RUN TestAccStatuspagePageAccessUser_Basic 2021/09/15 10:26:41 [DEBUG] POST https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:26:43 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:26:49 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:26:55 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:27:00 [DEBUG] DELETE https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users/464plwpsc06c 2021/09/15 10:27:00 [DEBUG] POST https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:27:00 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:27:05 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:27:20 [DEBUG] DELETE https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users/vk7dqyyrvm74 2021/09/15 10:27:20 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users/vk7dqyyrvm74 --- PASS: TestAccStatuspagePageAccessUser_Basic (49.15s) PASS ok github.com/sbecker59/terraform-provider-statuspage/statuspage 50.163s $ go test -v -run TestAccStatuspagePageAccessGroup_Basic ./statuspage === RUN TestAccStatuspagePageAccessGroup_Basic 2021/09/15 10:45:13 [DEBUG] POST https://api.statuspage.io/v1/pages/3szhmzxmsgd4/components 2021/09/15 10:45:13 [DEBUG] POST https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:45:15 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:45:20 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/components/sbdh4734hzvm 2021/09/15 10:45:20 [DEBUG] POST https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups 2021/09/15 10:45:20 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups/sqzknzr8ysk0 2021/09/15 10:45:26 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:45:26 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/components/sbdh4734hzvm 2021/09/15 10:45:26 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups/sqzknzr8ysk0 2021/09/15 10:45:34 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:45:34 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/components/sbdh4734hzvm 2021/09/15 10:45:34 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups/sqzknzr8ysk0 2021/09/15 10:45:38 [DEBUG] POST https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:45:38 [DEBUG] POST https://api.statuspage.io/v1/pages/3szhmzxmsgd4/components 2021/09/15 10:45:39 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:45:42 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/components/g8vbb5rlym1v 2021/09/15 10:45:42 [DEBUG] PATCH https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups/sqzknzr8ysk0 2021/09/15 10:45:42 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups/sqzknzr8ysk0 2021/09/15 10:45:48 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:45:48 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users 2021/09/15 10:45:48 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/components/g8vbb5rlym1v 2021/09/15 10:45:48 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/components/sbdh4734hzvm 2021/09/15 10:45:49 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups/sqzknzr8ysk0 2021/09/15 10:45:56 [DEBUG] DELETE https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups/sqzknzr8ysk0 2021/09/15 10:45:56 [DEBUG] DELETE https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users/4yk5kdxm491d 2021/09/15 10:45:56 [DEBUG] DELETE https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_users/m9t0f543n1h5 2021/09/15 10:45:56 [DEBUG] DELETE https://api.statuspage.io/v1/pages/3szhmzxmsgd4/components/g8vbb5rlym1v 2021/09/15 10:45:56 [DEBUG] DELETE https://api.statuspage.io/v1/pages/3szhmzxmsgd4/components/sbdh4734hzvm 2021/09/15 10:45:57 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups/4yk5kdxm491d 2021/09/15 10:45:58 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups/m9t0f543n1h5 2021/09/15 10:45:58 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups/sbdh4734hzvm 2021/09/15 10:45:58 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups/g8vbb5rlym1v 2021/09/15 10:45:58 [DEBUG] GET https://api.statuspage.io/v1/pages/3szhmzxmsgd4/page_access_groups/sqzknzr8ysk0 --- PASS: TestAccStatuspagePageAccessGroup_Basic (56.00s) PASS ok github.com/sbecker59/terraform-provider-statuspage/statuspage 57.259s ``` I occasionally got 404 on deletes for users, but running it again deletes them successfully. I think there's some sort of lag inbetween systems on big deletes.
sbecker59
reviewed
Sep 30, 2021
There was a problem hiding this comment.
Can you create two examples in examples/resources for the resources you added please?
This allows to have the documentation up to date in registry.terraform.io
You can also generate the documentation files via make docs. This command uses tfplugindocs
You should also have received a github invitation to become a collaborator of the project.
Thanks in advance.
Absolutely. I'll do that today. Sorry I missed that part. |
added 2 commits
September 30, 2021 09:53
|
@sbecker59 ok, examples added and docs generated. Thanks for being so responsive! |
|
Hi @grierj , I made a mistake while merging. Which means that you will not appear as a contributor to the project 😕 . |
No problem! I'll squash those commits and recreate the pull request. |
|
created #68 to replace this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need these for audience manipulation. Trying to follow the standard
patterns established here. Updated to the latest client version to pick
up all the page access user endpoints and api fixes
Full acceptance tests appear to be working
I occasionally got 404 on deletes for users, but running it again
deletes them successfully. I think there's some sort of lag inbetween
systems on big deletes.
Sorry about the whitespace changes, my IDE decided to go fmt them I think.