-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paq 1.0 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use different names for single repo operations (`clone`/`pull`) and bulk operations (`install`/`update`).
- closes #65 - Add vim.notify to the compat module. - Default to `verbose=false` - format
- update messages table - add summary at the end of operations - change list function a little bit - create `parse_name` - remove num_pkgs
store a list of environment variables when paq module is initialized, and append GIT_TERMINAL_PROMPT. This means that if env variables change, Paq will need to be cleared from the lua cache and `require`d again. This is not a fancy solution, but it works for now. - Fixes #77 - Fixes #82 - Also place command definitions at the top to keep all "global" actions together.
Add User events `PaqDoneInstall` and `PaqDoneUpdate`. Closes #71
The command `PaqRunHook` takes the name of a package as argument. The previous `PaqRunHooks` is deprecated. (better solution for #53)
Stick with `path` because it's the name given in the docs for the setup function.
To prevent PaqDone* events to be raised before a hook has completed executing.
Testing is now easier with User events and autocmds, although more tests wouldn't hurt.
Paq has had 3 different methods for removing packages: 1. Recursively walk the directory tree, removing files and directories with the `uv.fs_*` functions (this is verbose, but it works). 2. Calling `rm` with `uv.spawn`. This does nothing on Windows. See #69 3. Calling vim's `delete` function. This will try to read file names as regexes. I noticed when trying to delete VimTeX; see the aptly named `vimtex/test/test-get-main/test-ugly-paths/`. I've looked for ways to prevent this, but had no success. Number 1. is the only solution that works correctly on multiple platforms.
BREAKING CHANGE: - Remove the `hook` option. It's been deprecated since v0.6. - Remove `PaqRunHooks`. It's been an awful hack since it was introduced. The new `PaqRunHook` works much better. See #53
BREAKING CHANGE: Users should call `require('paq')` instead of `require('paq-nvim')`. The name `paq-nvim` has been deprecated since 0.9.
BREAKING CHANGE: paq now requires nvim 0.5 or greater.
When a merging a branch with multiple commits, GitHub will name the PR after the branch, so it's better to give meaningful names from now on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features
vim.notify
support. this function prints to:messages
by default, so nothing will change for those not overriding it.:help paq-autocommands
.Fixes
path
setup option is now read correctly:PaqClean
Breaking changes
paq-nvim
alias. Users should callrequire('paq')
insteadPaqRunHooks
withPaqRunHook
verbose
setup option now defaults to false. Messages like(up-to-date) foo
won't appear, instead a message likePaq: sync complete. 0 ok; 0 errors; 20 no-ops
will appear at the end (whereno-ops
indicate the packages already up-to-date). When there's nothing to install, it'll simply printPaq: Nothing to install