Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaqClean does nothing in Windows #69

Closed
Borwe opened this issue Aug 16, 2021 · 1 comment · Fixed by #72
Closed

PaqClean does nothing in Windows #69

Borwe opened this issue Aug 16, 2021 · 1 comment · Fixed by #72
Labels
bug Something isn't working

Comments

@Borwe
Copy link
Contributor

Borwe commented Aug 16, 2021

:PaqClean does nothing in windows 10 neovim 5.0
@Borwe Borwe mentioned this issue Aug 16, 2021
Merged
@savq savq added the bug Something isn't working label Aug 16, 2021
@jdambron
Copy link

I can confirm the issue. PaqClean have no effect when running on Windows.

@savq savq mentioned this issue Aug 20, 2021
Merged
@savq savq closed this as completed in #72 Aug 20, 2021
savq added a commit that referenced this issue Nov 28, 2021
@savq
fix: Use recursive walk to delete packages
8eeb92b 
Paq has had 3 different methods for removing packages:

1. Recursively walk the directory tree, removing files and directories
   with the `uv.fs_*` functions (this is verbose, but it works).

2. Calling `rm` with `uv.spawn`. This does nothing on Windows. See #69

3. Calling vim's `delete` function. This will try to read file names as
   regexes. I noticed when trying to delete VimTeX; see the aptly named
   `vimtex/test/test-get-main/test-ugly-paths/`. I've looked for ways to
   prevent this, but had no success.

Number 1. is the only solution that works correctly on multiple platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev savq/paq-nvim
3 participants
@Borwe @jdambron @savq