Rewrote at-root specs #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is blocking here? |
|
Nothing blocking this, just haven't had the time to look at it frankly. It'd be worth adding some specs for |
|
I got this. |
|
Done. That should be enough. |
|
Perfect! Thanks again In future please make sure you generated the output with the nested style. |
|
I believe this should be marked as "TODO" for libsass, because at-root is not yet implemented. This makes the CI fail. |
|
I've moved the at-root tests into the todo folder! I hope CI will now build correctly again! |
|
Thanks! |
|
Sorry guys. |
Apologies. |
This was referenced Jan 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.