-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement @at-root selectors #353
Comments
|
Thanks for the reply @nschonni. Is there any idea of what version Libsass is currently at? Does anyone have a linky for the thread ref above.... |
Why was this closed? Won't it be implemented? @akhleung, do you have any insights on this? Thanks a lot! |
We do want to implement it eventually. I would have been fine with leaving this issue open. In fact, I guess I'll re-open it. |
@akhleung, thanks for the update! BEM will be a lot easier to write with the at-root selector. |
I have created a small bounty on this issue. |
Would be awesome! |
Do we know if support for this has been added with the release of version 3.0? |
@mikeebee It wasn't. The milestone is set to |
@mzgol ok, thanks! |
A big chunk of this is related to #185. |
I bumped the bounty but it seems the plugin doesn't work as it still shows the previous amount. |
Specs added sass/sass-spec#175 |
SassMeister was using 3.1 beta for a little bit and tried it. Test Code: .outer {
content: 'outer';
@at-root {
.inner {
content: 'inner';
}
}
} Wrong Output: .outer {
content: 'outer';
@at-root {
.inner {
content: 'inner'; } }
} Expected: .outer {
content: 'outer';
}
.inner {
content: 'inner';
} |
Yep. I've started work in this today. It'll be in 3.2.
|
Awesome, keep up the good work! Libsass is a holy grail for me because it's performance. I still achieved 10 sec compilation time because of the huge codebase and many (not kidding, thousands) of map-get. (I know it has improvements in 3.1 but node-sass has still only 3.0). With the Ruby compiler this was around 40-50 sec, you can imagine how funny is that to work with :D |
All tests for |
This is implemented on master. It'll be in 3.2. |
👍 Thanks a lot! |
+1 |
So is this usable now? |
This will be in the next version on Libsass. |
Any update on this? |
@ciampo This works in latest libsass, do you experience any problems? |
@mzgol Having some issues while compiling the sass through gulp-sass, but I guess the problem is the gulp-sass not using an updated version of node-sass |
@ciampo From what I see |
@mzgol you're actually right, just realised we were using an outdated version of |
I have noticed that when using:
With this code:
The code gets compiled correctly but Autoprefixer breaks, however this does not happen when running Sass 3.3.5. I am currently using Codekit 2.0.4
Mixin Above:
Can someone double check this.
The text was updated successfully, but these errors were encountered: