Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Output path never sent to upstream? #379

Closed
am11 opened this issue Jul 31, 2014 · 0 comments · Fixed by #394 or #395
Closed

Output path never sent to upstream? #379

am11 opened this issue Jul 31, 2014 · 0 comments · Fixed by #394 or #395

Comments

@am11
Copy link
Contributor

am11 commented Jul 31, 2014

There seems to be an issue in binding.cpp, that the outFile path is never sent to upstream. The corresponding output-path in upstream is used for "file" member of source-map JSON and now to resolve relative URLs for source-map URL-string. See sass/libsass#441 and sass/libsass#455.

The weird thing is that the param is being captured in sass.js, but never appear in binding.cpp as ctx->outFile.
@am11 am11 mentioned this issue Aug 9, 2014
Merged
am11 added a commit to am11/node-sass that referenced this issue Aug 24, 2014
@am11
Binding: Send output path to upstream. (sass#379)
095b2c3
This was referenced Aug 24, 2014
Merged
Closed
am11 added a commit to am11/node-sass that referenced this issue Aug 24, 2014
@am11
Binding: Send output path to upstream. (sass#379)
3c8ab1c
am11 added a commit to am11/node-sass that referenced this issue Aug 24, 2014
@am11
Binding: Send output path to upstream. (sass#379)
ab6692d
am11 added a commit to am11/node-sass that referenced this issue Aug 24, 2014
@am11
Binding: Send output path to upstream. (sass#379)
9025a2e
am11 added a commit to am11/node-sass that referenced this issue Aug 24, 2014
@am11
Binding: Send output path to upstream. (sass#379)
2690c8b
am11 added a commit to am11/node-sass that referenced this issue Aug 24, 2014
@am11
Binding: Send output path to upstream. (sass#379)
965598b
am11 added a commit to am11/node-sass that referenced this issue Aug 24, 2014
@am11
Binding: Send output path to upstream. (sass#379)
c159e48
andrew pushed a commit that referenced this issue Aug 24, 2014
Merge pull request #394 from am11/master
a882994 
Binding: Send output path to upstream (#379)
am11 added a commit to am11/node-sass that referenced this issue Aug 24, 2014
@am11
Binding: Send output path to upstream. (sass#379)
d498365
am11 added a commit to am11/node-sass that referenced this issue Aug 24, 2014
@am11
Binding: Send output path to upstream. (sass#379)
b5ca634
@am11 am11 mentioned this issue Aug 24, 2014
Merged
am11 added a commit to am11/node-sass that referenced this issue Aug 24, 2014
@am11
Binding: Send output path to upstream. (sass#379)
b307957
am11 added a commit that referenced this issue Aug 25, 2014
@am11
Merge pull request #395 from am11/master
2b2c5d3 
Binding: Send output path to upstream (#379)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@am11