Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

build fail node-sass v0.9.3 #381

Closed
putaoshu opened this issue Aug 1, 2014 · 7 comments
Closed

build fail node-sass v0.9.3 #381

putaoshu opened this issue Aug 1, 2014 · 7 comments

Comments

@putaoshu
Copy link

putaoshu commented Aug 1, 2014

if css files is blank,

    var css = Sass.renderSync({
        data: sourceContent,
        includePaths: [path.dirname(source)],
        outputStyle: 'expanded'
    });

sourceContent is blank build fail

Assertion failed: (val->IsString()), function _NanGetExternalParts, file ../node_modules/nan/nan.h, line 1725.
@am11
Copy link
Contributor

am11 commented Aug 9, 2014

The error is same as reported in #362.
It's addressed by 31bc8ec via #367; awaiting review / merge.

@am11
Copy link
Contributor

am11 commented Aug 24, 2014

@andrew, this issue can also be closed as fixed! :)

@andrew andrew closed this as completed Aug 24, 2014
@andrew
Copy link
Contributor

andrew commented Aug 24, 2014

Thanks @am11, would you like to be added as a contributor?

@am11
Copy link
Contributor

am11 commented Aug 24, 2014

Sure, it would be an honor! 👍

@andrew
Copy link
Contributor

andrew commented Aug 24, 2014

@am11 I've added you now, please send PRs for any changes you wish to make, welcome to the team!

@am11
Copy link
Contributor

am11 commented Aug 24, 2014

Thanks! 😄

I will send few PRs right away for #379 and #380. For that matter, can we point libsass submodule dependency to the latest commit?

@andrew
Copy link
Contributor

andrew commented Aug 24, 2014

Sweet, updated libsass here: caad14f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants