Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolation in url() freezing #1931

Closed
sunkan opened this issue Feb 25, 2016 · 1 comment
Closed

Interpolation in url() freezing #1931

sunkan opened this issue Feb 25, 2016 · 1 comment

Comments

@sunkan
Copy link

sunkan commented Feb 25, 2016

If you have a space before the interpolation libsass freezes and nothing happens.

$var: 'http://test.com';
body {
  background-image: url( #{$var});
}

Tested in

node-sass: 3.4.2
sassc: 3.3.0-10-g8d3d
libsass: 3.3.3-28-g2ed7
sass2scss: 1.0.5

I only found it because i was upgrading some old scripts and they stopped working. But i think it's strange behavior for libsass to freeze.

It works as expected in ruby-sass

@xzyfer
Copy link
Contributor

xzyfer commented Feb 28, 2016

Thanks for the report @sunkan. I can confirm this issue. We heavily refactored url() handling in recent versions which may have caused this issue.

@xzyfer xzyfer added this to the 3.3.4 milestone Feb 28, 2016
@xzyfer xzyfer self-assigned this Feb 28, 2016
@xzyfer xzyfer modified the milestones: 3.3.4, 3.3.5 Mar 17, 2016
mgreter added a commit to mgreter/libsass that referenced this issue Apr 5, 2016
mgreter added a commit to mgreter/libsass that referenced this issue Apr 5, 2016
@mgreter mgreter assigned mgreter and unassigned xzyfer Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants