Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line comments should be relative to cwd #1898

Closed
xzyfer opened this issue Jan 27, 2016 · 4 comments
Closed

Line comments should be relative to cwd #1898

xzyfer opened this issue Jan 27, 2016 · 4 comments

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Jan 27, 2016

When displaying line comments in output Ruby Sass shows the file paths as relative to cwd, LibSass shows an absolute path.

Given

|- foo
|  |- bar.scss
|- test.scss

Running

sassc -l foo/bar.scss

Ruby Sass

/* line 1, ../test.scss */
a {
  color: black; }

/* line 3, bar.scss */
b {
  color: red; }

LibSass 3.3.3

/* line 1, /Sass/libsass/test.scss */
a {
  color: black; }

/* line 3, /Sass/libsass/foo/bar.scss */
b {
  color: red; }
@xzyfer xzyfer modified the milestone: 3.4.1 May 20, 2016
@mgreter mgreter modified the milestones: 3.4, 3.4.1 Oct 22, 2016
@mgreter mgreter self-assigned this Oct 22, 2016
@mgreter mgreter modified the milestones: 3.4.1, 3.4 Oct 22, 2016
@mgreter mgreter removed their assignment Oct 22, 2016
@mgreter
Copy link
Contributor

mgreter commented Oct 22, 2016

URLs by sass don't seem to be relative to CWD. That makes it harder to implement correctly ...

@mgreter mgreter modified the milestones: 3.4, 3.4.1 Oct 22, 2016
@mgreter
Copy link
Contributor

mgreter commented Oct 22, 2016

Retested again and it seems to be inline with ruby sass. Original test case here was not very clear where the import is as the contents of each file were not given in this issue.

@mgreter
Copy link
Contributor

mgreter commented Oct 22, 2016

@xzyfer Is it possible to switch on the line-comments flag via options.yml?

@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 22, 2016

@mgreter it is not. I would say it's out of scope for sass spec, much like sourcemaps and alternate output formats (except special compressed cases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants