Telemetry wip #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file should have been removed previously.
…ormation()` methods name in README (#4428)
- Downloads may occasionally fail due to server or network issues - Remove deprecated parameter UseBasicParsing
…4367) * Remove ServiceClientCredentials from ServiceClient API * Remove additional check added to isTokenCredential This rolls back the change made in 771614e because it will prevent forward-compatibility in `ms-rest-nodeauth` and `ms-rest-browserauth` credentials. * Improve RawTokenCredential comment * Improve credential detection logic in ServiceClient * Add isTokenCredential heuristic to identify TokenClientCredentials * Simplify ServiceClient constructor logic around credentials * Move RawTokenCredential from core-http to core-arm * Delete TokenCredentials, update samples to use RawTokenCredential * Rename RawTokenCredential to SimpleTokenCredential
* [Storage] Fixed a bug of `downloadBlobToBuffer()` and `downloadAzureFileToBuffer()` when provided offset is not 0. * [Storage] Fixed a bug that `Aborter` cannot work during retry interval. * [Storage] * Export `RetryPolicyType`. * [Storage] Fixed a bug that Aborter throws timeout error even though it succeeds of blobURL or fileURL download * [Storage] Aborter doesn't require `dom` as tsconfig lib requirement anymore for `Event` type. * [Storage] * Fixed a bug that "err.code.toUpperCase is not a function" when retries in browser * [Storage] Resolved CR comments * [Storage-Queue] Updated queue API version to 2018-11-09 * [Storage][Blob] Regenerated blob protocol layer code against swagger 2018-11-09; Updated to autorest 4.1.1 and ms-rest-js ^1.8.1 * [Storage-File] Updated API version to 2018-11-09; Updated to autorest.typescript 4.1.1 and ms-rest-js ^1.8.1; * [Storage-File] Fixed FileURL.create() and setHTTPHeaders() issues introduced by re-generation * Added `DirectoryURL.listHandlesSegment()` and `FileURL.listHandlesSegment()` to returns a list of open handles on a directory or a file. * Added `DirectoryURL.forceCloseHandlesSegment()`, `FileURL.forceCloseHandlesSegment()`, `DirectoryURL.forceCloseHandle()` and `FileURL.forceCloseHandle()` to close handles * [Storage-File] Updated recorded tests * [Storage-File] Updated package version to 10.2.0 * Rename handlerID parameter to handlerId * [Storage] Updated contribution.md about record and play * [Storage-File] Updated changelog and comments to make them clearer * [Storage-Blob] Updated ChangeLog * [Storage-Blob] PageBlobURL.uploadPagesFromURL() AppendBlobURL.appendBlockFromURL() BlobURL.syncCopyFromURL() * [Storage] Resolved CR comments * [Storage][Blob] Added ServiceURL.getUserDelegationKey() * [Storage] Update to ms-rest-js@2.x; Updated HTTP client from axios to node-fetch in Node.js runtime. Support keepalive; * [Storage] Updated samples about keepAliveOptions * [Storage] Updated changelog; Fixed testcases; Updated pnpmlock; * [Storage] Added vinjiang and Jason Fan as storage code owners * [Storage] Record test cases * [Storage] Force to YYYY-MM-DDThh:mmTZD precision for getUserDelegationKey start and expiry time * [Storage] Resolved PR comments; Updated contribution.md & API comments; Optimized generated code import paths;
- Continuation of #4333
…#4416) * [Event Hubs] Define classes and interfaces for EPH as per API design
- Suppress Rush warning for non-LTS versions
…lookup issues (#4465) * fix serialization issues in kusto * regenerated @azure/arm-timeseriesinsights to fix polymorphic mapper lookup
…nerating polymorphic mappers (#4468) * regenerated arm-servicemap * regenerated arm-edgegateway * regen arm-streamanalytics * regenerate graph
* regenerated arm-servicemap * regenerated arm-edgegateway * regen arm-streamanalytics * regenerate graph * add dom to tsconfig for graphrbac
* regenerated arm-servicemap * regenerated arm-edgegateway * regen arm-streamanalytics * regenerate graph * add dom to tsconfig for graphrbac * delete old files from the graph package.
* Generate @azure/arm-policy * Bump the version * Regenerate with older generator
- Bundle core-http instead of requiring as external
- Dependency was accidentally added with a `~` instead of `^`
- Assert mock session as any (required by bug fixes in @types/sinon)
- Update test code to react to bug fixes in @types/tunnel
* Initial port of template to Handlebars * Collect dependency info from package.jsons * Generate inconsistent dependency info * Remove lockfile processing * eslint and prettier * Sort everything in the HTML report * Exclude from docwarden
…etryable errors (#4565)
- Effectively a no-op, since "^0.0.X" is functionally equivalent to "0.0.X" - Clarifies this dependency should be floated rather than pinned
…st (#4553) * Add generator version in swagger_to_sdk_config.json to unblock autorest * Update swagger_to_sdk_config.json
* generate signalr mgmt plane package * Bump patch version * Revert change for libraries * bump major version due to api-version change * Update signalRManagementClientContext.ts
Add a new CryptographyClient to serve the cryptography functions for KV
- Add dev dependency to core-amqp - Script "unit-test:node" depends on ts-node
* [EPH] implement CheckpointManager methods
…ocs (#4612) Add README for CryptographyClient and samples to API docs
Tests and recordings
- Was required due to rollup/rollup-plugin-commonjs#394 - Fixed in rollup-plugin-commonjs@1.10.1
- resolve@1.12.0 causes a build break in storage-blob and storage-file - Related to the rollup-plugin-commonjs namedExports of "events"
* Add DeviceCodeCredential implementation * AuthenticationError should accept a pre-parsed error response * Enable MockAuthHttpClient to return multiple configured responses * Add tests for DeviceCodeCredential * An offering to the eslint gods * Add refresh token support for DeviceCodeCredential * Handle "interaction_required" errors when refreshing access token * Update UsernamePasswordCredential with new design changes
sarangan12
pushed a commit
that referenced
this pull request
Jul 14, 2020
Minor tweaks to package.json and source files
sarangan12
pushed a commit
that referenced
this pull request
May 9, 2022
* sms core v2 migration changes * fixed build issue * unit test fixes * record test mode fix * recording updated * migrated to new test recorder version * Make the tests pass (#2) format and test fixes * recording update & code owner update * analyzer fix * update code owner for sms Co-authored-by: Petr Švihlík <rocky.intel@gmail.com>
sarangan12
pushed a commit
that referenced
this pull request
Mar 3, 2023
* Update maps dependency in pnpm-lock.yaml * Fix sample metadata errors * Fix linting errors * Fix linting errors * Fix run time error * Update package.json in samples folder * Fix linting errors * Fix linting errors * Add changelog for maps-common * Update recording files for maps-search * Add test.yml for maps-search * Add tests.yml for render and route * Update tests.yml * Update test-resources.json for maps * Fix tests.yml format error * Update env vars and remove unused export var * Remove unused code * Fix lock file * Remove route & render * Replace `beginGet*Batch` with `resume*Batch` We provide a `beginGet*Batch` method to resume the previous request previously. This is not ideal because it need to get a `batchId` which is store in the internal state of the LRO. Once the LRO brings changes, our code will be broken. We can achieve the same thing by using serialized state. This change aims to leverage this approach and create convenience methods `resume*Batch` for users * Update recording * Make the endpoint of `MapsSearchClient` configurable * Change LatLon from an interface to a tuple Also remove the `toLatLon` function since creating a tuple is quite easy. * Make the props `coordinates` and `countryCodeFilter` optional Specifying `coordinates` and `countryCodeFilter` can narrow the results of the fuzzy search. But considring the case like searching "Australia", theese fields may have no use. We decided to make them optional so user can decides if they want to narrow down the results or not. * fixup! Remove route & render * Adjust CHANGELOGs of maps-search & common Following the keyvault-common, removing CHANGELOGs from maps-common since it's not published. * Update samples * Add batchRequest sample * Add a new sample searchAddressResult * Update search.ts and its examples * enhance code example in README.md * comment unused import * Update recording for maps-search * remove redundant recording files * Add maps-search * Rename LatLong to LatLon * Fix constructor Readme doc * Update readme to new signature * Add tests partially * Change LatLon/BoundingBox to interfaces * Reduce the number of constructor overloading * Rename SearchClient as MapsSearchClient * Add options mapper tests * Add result type mapper tests (in progress) * rename clientId to mapsAccountClientId * listPolygons -> getPolygons * getPointOfInterestCategoryTree -> getPointOfInterestCategories * Expose missing model * Add alternative input file for quick experiment * Regenerate code and make changes accordingly * Reduce number of overloads of fuzzy searches * Add geojson types * Adopting new geojson definitions * Change test specs to align with new method names * clean up models and tsconfig * Expose Known* models * Remove batch sync methods * Add public tests (non-batch) * move model * Add docstrings * Start polling in begin* method * Refactor BatchPoller for retrieving batchId * Finalize batch pollers * Readd batch methods * Update generated code * Finalize batch signature * Rebuild samples & clean up * Add AAD tests * Clean up Swagger readme * Fix spelling * Add initial files for @azure/maps-route module * maps-search: change comments and perform formatting * Methods options and testing skeleton for maps-route * maps-search: refactor options * Improve convenience layer for non-LRO methods * Change variable names * Complete batch methods * update maps-search Readme * Update maps-route Readme * Add generated samples for maps-route * Update samples for maps-search * Delete backup file * Add maps-common module * Update maps-route/maps-search to use maps-common * maps-render: first draft * Use LatLon/BoundingBox from maps-common * Complete maps-render with tests * Expose required types from maps-route * Expose required types from maps-search * Complete unit tests for maps-render * Update maps-render README * Update samples * Fix comment/strings * Fix comment/strings * Update Route comment/interface * Regenerate code * Update files * Define required fields and fix code * Remove non-poller batch methods * Fix playback test failure * Rename parts of model names * Rename remaining parts of models according to review feedback * Remove TODO comments * Update Reamdme transform to reflect latest swagger * Change key policy name * Simplify batch item error model * Add brower tests * Turn maps-common into internal module * Rearrange Readme * Rewrite Readme for common * Remove batch-sync methods * Route required fields: part 1 * Route required fields: part 2 * Add AAD back * Route model fixes #1 * Route model fixes #2 + geojson named tuples * Refine geojson types * Aliased a few method options * maps-render required fields part 1 * Do not validate budget parameters * Revert "Do not validate budget parameters" This reverts commit 4ec3f5f. * Rename MapTileset to TileJson * Render: model rename & type improvement * Explicitly transform image range * Fix route record tests * Update map account creation commands in Readme * Update Readme/docstrings/samples for Search/Route/Render * Remove rollup and use dev-tool instead * Remove some empty tests * Add AAD test case and make file name shorter * Update test cases * Update cspell rules * Update recording files * Simplify test cases * Sync cspell.json from upstream * Use test-recorder 2.0 and update unit test cases * Push wrong browsers recording files * Update settings to support recording * Fix dependency errors * Upgrade api-recorder and fix errors * Code refinement * Update maps search recording files * Update karma.conf.js format * Update recording files and settings * Fix broken links * Update maps dependency in pnpm-lock.yaml * Fix sample metadata errors * Fix linting errors * Fix linting errors * Fix run time error * Update package.json in samples folder * Fix linting errors * Fix linting errors * Add changelog for maps-common * Update recording files for maps-search * Add test.yml for maps-search * Add tests.yml for render and route * Update tests.yml * Update test-resources.json for maps * Fix tests.yml format error * Update env vars and remove unused export var * Remove unused code * Fix lock file * Remove maps-render * fixup! Change LatLon from an interface to a tuple * Comment the future doc link * Update doc & fix type issue * fix lint issues * Regenerate API View * Comment the whole [apiref] since the original syntax cannot pass the Analyze/Link verification * Fix issue related to the change of maps-common - Replace beginGet*Result with resume* methods - Turn LatLon to a tuple - Add mapper to transform the string to Date because resume* method will return a serialized Date * Update test recording * Remove maps-common from the Artifacts * remove unused dependencies * Add impression in README so we can track the page views * Remove `AZURE_LOG_LEVEL` in test.yml * Update samples - Move the option parameter to the right place - Add comments & "break" for handling the type of the search result to make it clear for the user * Patch {} to properties for GeoJsonPolygon * rename maxDetourTime to maxDetourTimeInSeconds * Update recordings * Remove any * Rename to detourTimeInSeconds to align the convention * Change the test.yml EnvVar See more explanation here: - Azure#23039 (comment) - Azure#23039 (comment) * Rename numResults to numberResults * Add document comment * Add endpoint options to MapsRouteClient * Remove unused dependencies in maps-route * fixup! Change the test.yml EnvVar * Update interfaces & documents * Update changelog * Merge getRouteDirection with the additional parameter one * Update samples * Make the `maps-common to a published package * Update the import of `maps-common` in `maps-search` * Fix CI Issue * Add documents for geojson * Update the samples & readme * Leverage maps-common package in mpas-route * chore update - Remove the unnecessary rule setting of eslint - Update the legacy type path * Remove unnecessary eslint config * WIP: Remove LRO generation * WIP: refactor mapsRouteClient * WIP: first generation * Format the generated code * Support AAD * Transform the model name * Add helper functions * Add a sample - route.ts * Add samples for lro * Add test * Generate samples * Add api view * Update the generation * WIP: ReadMe * Rename "computeBestOrder" to "computeBestWaypointOrder" * Refine README * Rename model * Add test createRouteDirectionsBatchRequest * Fix lint issue * Add missing metadata * Remove maps-route/ * Update CI issue * Fix merged issue * Update version rule for maps-common * Update CI name * Remove extra lint config * Use `require` in the README for consistency * Regenerate the samples * Remove redundant recording files * Remove unused parameters in test-resources.json * Refine readme snippet * Log something specific for the result * Update samples * Split the route.ts into 3 * Remove model rename * Use default export for RLC factory function Co-authored-by: Charlie Chen <charlie.chen@microsoft.com> Co-authored-by: Charlie Chen <yuchungchen@microsoft.com> Co-authored-by: --global <alankashiwa@gmail.com>
sarangan12
pushed a commit
that referenced
this pull request
Mar 3, 2023
* initial changes stableversion * old files modified * Added polling Helper * Added initial sample and tests * Added API Review * Added samples for JS and TS * pnpm lock file and Readme Update * Added test and removed locale from readme * Corrected broken links * Added dev-tool and eslint * formatting changes * Added Browser Recordings * Code generated from main API * Added Test Recordings * Added Samples for JS and TS * Added Validation Poller * added champion scenario in single file * added stop and delete samples * Update sdk/loadtestservice/load-testing-rest/package.json Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> * added TestRun LRO * modified upload and validte LRO * Single Test File for test and testrun * Samples and LRO changes * Create Test in LRO removed from sample * Update sdk/loadtestservice/load-testing-rest/src/beginCreateOrUpdateTestRun.ts Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> * Update sdk/loadtestservice/load-testing-rest/src/beginUploadTestFile.ts Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> * Samples and LRO changes as per review * Added timeout in samples and test recordings * New Samples generated and corrected broken link * Update sdk/loadtestservice/load-testing-rest/samples-dev/stopTest.ts Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> * Update sdk/loadtestservice/load-testing-rest/samples-dev/stopTest.ts Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> * Update sdk/loadtestservice/load-testing-rest/src/beginUploadTestFile.ts Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> * Added Sleep Utility * Updated Readme * Updated Changelog * Updated LRO to take queryparams * Added Tests for LRO impl * Generated latest Samples * GetLROHelper Similar impl * Review Comment Changes * Updated imports * LRO error condtions corrected * Added AbortSignal Changes * Added LRO Tests * Removed Begin Methods and added new recordings for tests * Corrected Broken Links * rush file update * build failure due to core-http formatting * LRO Helper Changes Done * Ran API extractor again * Running empty tests * Review Comments LRO Helper * New API review * LRO helper refactoring * Updated Samples and Readme * Throw Error when Abort * Updated Sample * Updated API View * Updated package.json, Readme and Samples * Updated Release date and core-client version Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.