Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup type hints + spelling, source API links #64

Merged
merged 12 commits into from
Mar 2, 2022

Conversation

ryancoe
Copy link
Collaborator

@ryancoe ryancoe commented Mar 1, 2022

Description

As I am using the fancy new VS Code IDE, I was made aware of a couple minor mistakes in our type hints and spelling typos.

Checklist for PR

@ryancoe ryancoe added the documentation Improvements or additions to documentation label Mar 1, 2022
@ryancoe ryancoe self-assigned this Mar 1, 2022
@ryancoe ryancoe changed the title Type hints cleanup Type hints and spelling cleanup Mar 1, 2022
@ryancoe ryancoe requested a review from cmichelenstrofer March 1, 2022 02:40
Copy link
Member

@cmichelenstrofer cmichelenstrofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a lot of typos! Maybe I don't have spell check on in VS Code.

@ryancoe
Copy link
Collaborator Author

ryancoe commented Mar 1, 2022

I'm going to hold off until #53 is merged and then update type | None to Optional[type]

@ryancoe ryancoe changed the title Type hints and spelling cleanup Cleanup type hints + spelling, source API links Mar 2, 2022
@ryancoe ryancoe merged commit 27cf9b3 into sandialabs:main Mar 2, 2022
@ryancoe ryancoe deleted the type_hints_cleanup branch March 2, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants