explicit buoyancy/gravity #53
Conversation
…ity' into explicit_buoyancy_gravity
|
@cmichelenstrofer - I think I have the source updated appropriately. Last key step is to write a test to check that you can have a body that is not neutrally buoyant but that can be stabilized by including the appropriate entries in |
conda activate wecopttool merge branch 'main' into explicit_buoyancy_gravity
…ravity manually resolvled merge conflict for: tutorial_2_wavebot_optimization.ipynb
avoids mutation of wec object
|
This documentation build error is related to https://doi.org/10.2172/1330189, which should point to https://www.osti.gov/biblio/1330189-advanced-wec-dynamics-controls-fy16-testing-report. I think OSTI is may just having a problem this morning. I really prefer to use the DOI URL, so let's give it a bit and see if it resolves. EDIT: looks like many (all?) of OSTI's DOI links are broken, so I expect this will get fixed pretty quickly |
|
Per conversation w. @cmichelenstrofer, @ryancoe will add documentation on this. Will work on example (#61) later. |
There was a problem hiding this comment.
Looks good! Documentation builds, tutorials run, tests pass. I even learned a few new Python tricks (callable, Mappable, Optional). The only comment is to add another sentence to the documentation about restoring moments.
Also, because this is in my fork, I cannot approve it.
Description
Fixes #49 by changing the
f_addargument for theWECclass to be adict(user can also pass a function handle, which will get stored asf_add = {'f_add': argument_from_user}). This allows for automate post-processing so that eachf_addentry can be plotted in the frequency and time domain.Checklist for PR