fix: revert to node16, build to mjs, and use more modern ulid package #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was there anything wrong with the ulid library |
sam-goodwin
reviewed
Nov 19, 2022
Comment on lines
+84
to
+94
| /** | ||
| * Allows ESM module bundles to support dynamo requires when necessary. | ||
| */ | ||
| function esmPolyfillRequireBanner() { | ||
| return { | ||
| js: [ | ||
| `import { createRequire as topLevelCreateRequire } from 'module'`, | ||
| `const require = topLevelCreateRequire(import.meta.url)`, | ||
| ].join("\n"), | ||
| }; | ||
| } |
There was a problem hiding this comment.
Does this mess with source maps
There was a problem hiding this comment.
Looks like it will not break them
It had not been updated since 2018, was not being maintained, and had dynamic |
sam-goodwin
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ulidwithulidxasulidhas not been updated in 5 years and contains dynamic requires.