fix: revert to node16, build to mjs, and use more modern ulid package (…

…#28)

apps/test-app-runtime/package.json

@@ -13,8 +13,7 @@
     "@aws-sdk/client-lambda": "^3.204.0",
     "@aws-sdk/lib-dynamodb": "^3.204.0",
     "@eventual/aws-runtime": "workspace:^",
-    "@eventual/core": "workspace:^",
-    "ulid": "^2.3.0"
+    "@eventual/core": "workspace:^"
   },
   "devDependencies": {
     "@eventual/compiler": "workspace:^",

apps/test-app/package.json

@@ -11,8 +11,7 @@
   },
   "dependencies": {
     "aws-cdk-lib": "^2.50.0",
-    "constructs": "^10.1.154",
-    "ulid": "^2.3.0"
+    "constructs": "^10.1.154"
   },
   "devDependencies": {
     "@eventual/aws-cdk": "workspace:^",

packages/@eventual/aws-cdk/package.json

@@ -9,8 +9,7 @@
   "dependencies": {
     "@aws-cdk/aws-apigatewayv2-authorizers-alpha": "2.50.0-alpha.0",
     "@eventual/aws-runtime": "workspace:^",
-    "@eventual/compiler": "workspace:^",
-    "ulid": "^2.3.0"
+    "@eventual/compiler": "workspace:^"
   },
   "peerDependencies": {
     "aws-cdk-lib": "^2.50.0",

packages/@eventual/aws-cdk/src/workflow.ts

@@ -4,6 +4,7 @@ import {
   Function,
   Code,
   IFunction,
+  Runtime,
 } from "aws-cdk-lib/aws-lambda";
 import { Construct } from "constructs";
 import { Bucket, IBucket } from "aws-cdk-lib/aws-s3";
@@ -25,7 +26,6 @@ import { SqsEventSource } from "aws-cdk-lib/aws-lambda-event-sources";
 import path from "path";
 import { execSync } from "child_process";
 import { IGrantable, IPrincipal } from "aws-cdk-lib/aws-iam";
-import { NODE_18_X } from "./utils";
 
 export interface WorkflowProps {
   entry: string;
@@ -109,7 +109,7 @@ export class Workflow extends Construct implements IGrantable {
           "../../esm/functions/start-workflow.js"
         ),
         handler: "handle",
-        runtime: NODE_18_X,
+        runtime: Runtime.NODEJS_16_X,
         architecture: Architecture.ARM_64,
         bundling: {
           // https://github.com/aws/aws-cdk/issues/21329#issuecomment-1212336356
@@ -151,7 +151,7 @@ export class Workflow extends Construct implements IGrantable {
       code: Code.fromAsset(path.join(outDir, "activity-worker")),
       // the bundler outputs activity-worker/index.js
       handler: "index.default",
-      runtime: NODE_18_X,
+      runtime: Runtime.NODEJS_16_X,
       memorySize: 512,
       environment: {
         NODE_OPTIONS: "--enable-source-maps",
@@ -173,7 +173,7 @@ export class Workflow extends Construct implements IGrantable {
       code: Code.fromAsset(path.join(outDir, "orchestrator")),
       // the bundler outputs orchestrator/index.js
       handler: "index.default",
-      runtime: NODE_18_X,
+      runtime: Runtime.NODEJS_16_X,
       memorySize: 512,
       environment: {
         NODE_OPTIONS: "--enable-source-maps",

packages/@eventual/aws-runtime/package.json

@@ -17,7 +17,7 @@
     "aws-lambda": "^1.0.7",
     "fast-equals": "^4.0.3",
     "micro-memoize": "^4.0.11",
-    "ulid": "^2.3.0",
+    "ulidx": "^0.3.0",
     "aws-embedded-metrics": "^4.0.0"
   },
   "peerDependencies": {

packages/@eventual/aws-runtime/src/clients/execution-history-client.ts

@@ -11,7 +11,7 @@ import {
   isHistoryEvent,
   WorkflowEvent,
 } from "@eventual/core";
-import { ulid } from "ulid";
+import { ulid } from "ulidx";
 
 export interface ExecutionHistoryClientProps {
   readonly dynamo: DynamoDBClient;

packages/@eventual/aws-runtime/src/clients/workflow-client.ts

@@ -12,7 +12,7 @@ import {
   WorkflowEventType,
   HistoryStateEvents,
 } from "@eventual/core";
-import { ulid } from "ulid";
+import { ulid } from "ulidx";
 import { ExecutionHistoryClient } from "./execution-history-client.js";
 
 export interface WorkflowClientProps {

packages/@eventual/compiler/src/eventual-bundle.ts

@@ -33,9 +33,9 @@ async function main() {
         conditions: ["module", "import", "require"],
         // supported with NODE_18.x runtime
         // TODO: make this configurable.
-        external: ["@aws-sdk"],
+        // external: ["@aws-sdk"],
         platform: "node",
-        format: "cjs",
+        format: "esm",
         metafile: true,
         bundle: true,
         entryPoints: [
@@ -44,7 +44,9 @@ async function main() {
             "../../esm/entry/orchestrator.js"
           ),
         ],
-        outfile: path.join(outDir, "orchestrator/index.js"),
+        // // ulid
+        banner: esmPolyfillRequireBanner(),
+        outfile: path.join(outDir, "orchestrator/index.mjs"),
       })
       .then(writeEsBuildMetafile(path.join(outDir, "orchestrator/meta.json"))),
     esbuild
@@ -59,9 +61,9 @@ async function main() {
         conditions: ["module", "import", "require"],
         // supported with NODE_18.x runtime
         // TODO: make this configurable.
-        external: ["@aws-sdk"],
+        // external: ["@aws-sdk"],
         platform: "node",
-        format: "cjs",
+        format: "esm",
         metafile: true,
         bundle: true,
         entryPoints: [
@@ -70,14 +72,27 @@ async function main() {
             "../../esm/entry/activity-worker.js"
           ),
         ],
-        outfile: path.join(outDir, "activity-worker/index.js"),
+        banner: esmPolyfillRequireBanner(),
+        outfile: path.join(outDir, "activity-worker/index.mjs"),
       })
       .then(
         writeEsBuildMetafile(path.join(outDir, "activity-worker/meta.json"))
       ),
   ]);
 }
 
+/**
+ * Allows ESM module bundles to support dynamo requires when necessary.
+ */
+function esmPolyfillRequireBanner() {
+  return {
+    js: [
+      `import { createRequire as topLevelCreateRequire } from 'module'`,
+      `const require = topLevelCreateRequire(import.meta.url)`,
+    ].join("\n"),
+  };
+}
+
 function writeEsBuildMetafile(path: string) {
   return (
     esbuildResult: esbuild.BuildResult & { metafile: esbuild.Metafile }