Issues/23373 reactor race condition #27864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DmitryKuzmenko I think you'll want to also look at #27843 for an alternative implementation. |
|
@cachedout saw it yesterday, just shared my solution. Now I'm looking to Tom's solution in details. At least it looks closer to Tornado and more Pythonic. |
added 8 commits
October 13, 2015 13:20
...to guarantee always exit on break
The dict wrapper keeps different dict instances for different threads
If highstate dict contatins mix of key to dict and key to any other object outputter throws error.
|
@DmitryKuzmenko Sounds good. I was just making sure you saw it. Thanks! |
ada2b27 to
ec0e25c
Compare
|
@cachedout thank you for taking care of this =) |
|
I've picked bugfixes for the existing non-related bugs from this PR and published them as separate PRs. The main bugfix would be done by Thomas so I close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please DO NOT immediately merge
My approach for #23373