Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salt command line argument --pillar confuses loader setting opts['pillar'] to boolean value. #27901

Closed
DmitryKuzmenko opened this issue Oct 13, 2015 · 1 comment
Closed

Salt command line argument --pillar confuses loader setting opts['pillar'] to boolean value. #27901

DmitryKuzmenko opened this issue Oct 13, 2015 · 1 comment
Assignees
@DmitryKuzmenko
Labels
Bug broken, incorrect, or confusing behavior Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Core relates to code central or existential to Salt fixed-pls-verify fix is linked, bug author to confirm fix ZRELEASED - Boron
Milestone
B 10

Comments

@DmitryKuzmenko
Copy link
Contributor

Found during debug, currently isn't visible externally, but wrong by design.
--pillar command line argument sets 'pillar' key to True or False in self.config via self.defaults that is used as a loader argument where opts data expected. If opts contains 'pillar' it expects it to be a dict object containing pillar data, not bool.

The easiest way to fix is to set another target for --pillar command line, for instance 'use_pillar' instead of 'pillar'.
DmitryKuzmenko pushed a commit to DSRCorporation/salt that referenced this issue Oct 13, 2015
Temporary workaround for saltstack#27901
ec0e25c
@DmitryKuzmenko DmitryKuzmenko mentioned this issue Oct 14, 2015
Merged
@DmitryKuzmenko DmitryKuzmenko added Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix Core relates to code central or existential to Salt Confirmed Salt engineer has confirmed bug/feature - often including a MCVE ZRELEASED - Beryllium labels Oct 14, 2015
@DmitryKuzmenko DmitryKuzmenko added this to the B 10 milestone Oct 14, 2015
@DmitryKuzmenko DmitryKuzmenko self-assigned this Oct 14, 2015
@DmitryKuzmenko
Copy link
Contributor Author

Found this while worked on #23373
Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitryKuzmenko DmitryKuzmenko

Labels
Bug broken, incorrect, or confusing behavior Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Core relates to code central or existential to Salt fixed-pls-verify fix is linked, bug author to confirm fix ZRELEASED - Boron
Projects
None yet
Milestone
B 10
Development

No branches or pull requests
2 participants
@cachedout @DmitryKuzmenko