fix(): Pass proper args to the rabbitmq user state

[dahrens]

PR progress checklist (to be filled in by reviewers)

• Changes to documentation are appropriate (or tick if not required)
• Changes to tests are appropriate (or tick if not required)
• Reviews completed

---

What type of PR is this?

Primary type

• [build] Changes related to the build system
• [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ci] Changes to the continuous integration configuration
• [feat] A new feature
• [fix] A bug fix
• [perf] A code change that improves performance
• [refactor] A code change that neither fixes a bug nor adds a feature
• [revert] A change used to revert a previous commit
• [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [docs] Documentation changes
• [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Restores the behavior changed by 346df02

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

• Updated the README (e.g. Available states).
• Updated pillar.example.

Testing checklist

• Included in Kitchen (i.e. under state_top).
• Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• Updated the relevant test pillar.

Additional context

Without this patch the state is rendered like that:

rabbitmq-config-user-present-{{ name }}:
  rabbitmq_user.present:
    - name: {{ name }}
    -
      - password: foo
      - tags: ['administrator']
    - require: [...]

Which leads to creation, but without e.g. the tags being applied.
This looks a little awkward in YAML, but was revealed when asking salt to render: salt-call state.show_sls rabbitmq.

[dahrens]

Force pushing the feature branch to adjust the commit message to pass the commitlint check did not trigger the checks again. Can anyone trigger them manually or should I create a new PR?

[myii]

Force pushing the feature branch to adjust the commit message to pass the commitlint check did not trigger the checks again. Can anyone trigger them manually or should I create a new PR?

@dahrens Don't worry, the GitLab CI will still run without intervention. Your commit message still needs some adjustment to be accepted by commitlint:

-fix(user): Pass proper args to the rabbitmq state.
+fix(user): pass proper args to the rabbitmq state

[noelmcloughlin]

@dahrens looks good and could be merged once commit messages are fixed. @myii This change is also included in #75

[myii]

@dahrens Unfortunately, that needs to be lowercase pass instead of Pass.

[dahrens]

@dahrens Unfortunately, that needs to be lowercase pass instead of Pass.

I'm currently installing commitlint to get out of this trap... 🙃

[myii]

@dahrens We have pre-commit configured for this repo, so you could use that instead, to perform all the linting:

• https://github.com/saltstack-formulas/rabbitmq-formula#pre-commit

[saltstack-formulas-travis]

🎉 This PR is included in version 1.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀