-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cluster): rabbitmq clustering support #75
Merged
noelmcloughlin
merged 11 commits into
saltstack-formulas:master
from
noelmcloughlin:cluster1
Jun 16, 2021
Merged
feat(cluster): rabbitmq clustering support #75
noelmcloughlin
merged 11 commits into
saltstack-formulas:master
from
noelmcloughlin:cluster1
Jun 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noelmcloughlin
force-pushed
the
cluster1
branch
2 times, most recently
from
June 6, 2021 21:38
727e3ac
to
26e9a3f
Compare
noelmcloughlin
force-pushed
the
cluster1
branch
2 times, most recently
from
June 6, 2021 21:54
bad03b6
to
4108523
Compare
noelmcloughlin
force-pushed
the
cluster1
branch
15 times, most recently
from
June 15, 2021 07:26
7fb5994
to
d7fe076
Compare
19 tasks
Selfie merging. Thanks, @myii for fixing _metadata issue. |
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
This PR introduces a working solution for clustering support by managing "erlang cookie" and providing better documentation on clustering in the README and pillar.example files. Verified on CentOS7.
Some minor "bugs" fixed.
Pillar / config required to test the proposed changes
See "cluster" section in pillar.example.
Debug log showing how the proposed changes work
Result of running
rabbitmq.cofig.cluster
state on a member named host2 to join cluster on host1.Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context