Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conda workflow #35465

Merged
merged 4 commits into from
Apr 23, 2023
Merged

Fix conda workflow #35465

merged 4 commits into from
Apr 23, 2023

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Apr 9, 2023 •
edited
Loading

📚 Description

Fixes the following issues for the conda workflow:

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tobiasdiez tobiasdiez added the s: run conda ci Run the conda workflow on this PR. label Apr 9, 2023
@tobiasdiez tobiasdiez requested a review from mkoeppe April 9, 2023 05:48
@tobiasdiez tobiasdiez added s: needs review s: run conda ci Run the conda workflow on this PR. and removed s: run conda ci Run the conda workflow on this PR. labels Apr 9, 2023
@tobiasdiez tobiasdiez requested a review from isuruf April 9, 2023 05:55
@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 9, 2023

  • the detection doesn't work currently for some reason (it doesn't print anything

Do you have access to the config.log in this workflow?

@tobiasdiez
Copy link
Contributor Author

config.log

This my local log (where I could reproduce the rpy2 issue).

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 9, 2023 •
edited
Loading

Excluding rpy2 there is the correct thing to do. It's unrelated to "semistandard"; what's happening is that it does have an spkg-configure.m4, but its only purpose is to implement the logic wrt system R. So --with-system-rpy2=force will always fail.
We also need to update the instructions in the installation manual!

@tobiasdiez tobiasdiez added s: run conda ci Run the conda workflow on this PR. and removed s: run conda ci Run the conda workflow on this PR. labels Apr 13, 2023
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: dbf4a0c

mkoeppe
mkoeppe approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get this in ASAP

@isuruf
Copy link
Member

isuruf commented Apr 13, 2023

I'm sorry I didn't follow this thread. What's wrong with rpy2?

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 13, 2023

Nothing wrong with it in conda.
It's just a workaround for a quirk in our configure script.

@vbraun vbraun merged commit 957e627 into sagemath:develop Apr 23, 2023
@tobiasdiez tobiasdiez deleted the conda_deps branch April 23, 2023 12:39
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

@isuruf isuruf Awaiting requested review from isuruf

Assignees
No one assigned
Labels
s: run conda ci Run the conda workflow on this PR.
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasdiez @mkoeppe @isuruf @vbraun