rpy2: Document that it is a "semistandard" package
#35347
Milestone
Comments
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jun 10, 2024
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> As a follow-up on: - sagemath#35237 we make `rpy2` a dynamically detected feature, enabling the automatic run of doctests tagged `# optional - rpy2`; we use a file-level doctest tag for the `r.py` file. We also update the spkg documentation for sagemath#35347 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> Resolves sagemath#35347 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#35237 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35396 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jun 16, 2024
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> As a follow-up on: - sagemath#35237 we make `rpy2` a dynamically detected feature, enabling the automatic run of doctests tagged `# optional - rpy2`; we use a file-level doctest tag for the `r.py` file. We also update the spkg documentation for sagemath#35347 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> Resolves sagemath#35347 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#35237 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35396 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jun 16, 2024
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> As a follow-up on: - sagemath#35237 we make `rpy2` a dynamically detected feature, enabling the automatic run of doctests tagged `# optional - rpy2`; we use a file-level doctest tag for the `r.py` file. We also update the spkg documentation for sagemath#35347 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> Resolves sagemath#35347 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#35237 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35396 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
... in the
SPKG.rstofrandrpy2.Also, for dummy packages such as
r, do not show the message "If the system package is installed, ./configure willcheck whether it can be used."
see https://groups.google.com/g/sage-devel/c/0Rl6YbnPNmM
Also use the
featureargument in thelazy_importofrpy2insage.interfaces.r, so that system package info will be displayed when rpy2 is not installed.The text was updated successfully, but these errors were encountered: