spkg-configure.m4 for giac #29541

thierry-FreeBSD · 2020-04-21T16:26:50Z

This ticket adds an spkg-configure.m4 for giac, in order to use it from a system package if possible.

https://repology.org/project/giac/versions

See also:

Upgrade giac to 1.6.0-47 #30537 Upgrade giac to 1.6.0-7

CC: @dimpase @orlitzky @kiwifb @frederichan-IMJPRG @sagetrac-parisse @sheerluck @antonio-rojas @kliem @tobihan

Component: build: configure

Keywords: spkg-configure giac

Author: Thierry Thomas, Matthias Koeppe

Branch/Commit: 0df15df

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/29541

The text was updated successfully, but these errors were encountered:

thierry-FreeBSD · 2020-04-21T16:28:30Z

spkg-configure.m4 to be put under build/pkgs/giac/

mkoeppe · 2020-04-21T17:03:19Z

comment:1

Attachment: spkg-configure.m4.gz

mkoeppe · 2020-08-10T17:37:45Z

comment:4

Do we know which versions of system giac are acceptable? According to our update tickets (see #29552) >= 1.5.0-63 and < 1.6 are fine.

What does the check for ConvertUTF16toUTF8 in the proposed spkg-configure.m4 test? Does this test for a minimum version?

Is there a way to test the patchlevel of giac? giac --version does not include this information.

mkoeppe · 2020-08-10T23:26:46Z

Changed author from gh-thierry-FreeBSD to Thierry Thomas

mkoeppe · 2020-08-10T23:30:43Z

Branch: u/mkoeppe/spkg_configure_m4_for_giac

sagetrac-git · 2020-08-10T23:38:06Z

Commit: 43ee06b

sagetrac-git · 2020-08-10T23:38:06Z

Branch pushed to git repo; I updated commit sha1. New commits:

`43ee06b`	`build/pkgs/giac/distros: Add debian, fedora, opensuse`

mkoeppe · 2020-08-10T23:41:23Z

Changed author from Thierry Thomas to Thierry Thomas, Matthias Koeppe

mkoeppe · 2020-08-10T23:41:23Z

Reviewer: github.com/mkoeppe/sage/actions/runs/203238491

mkoeppe · 2020-08-12T03:46:55Z

comment:9

ubuntu-focal-standard (https://github.com/mkoeppe/sage/runs/969005184), debian-bullseye-standard: pexpect.exceptions.ExceptionPexpect: The command was not found or was not executable: giac.
So some package is still missing

mkoeppe · 2020-08-12T03:52:26Z

comment:10

fedora-32-standard (https://github.com/mkoeppe/sage/runs/969005556):

Checking whether SageMath should install SPKG giac...
checking whether any of pari is installed as or will be installed as SPKG... no
checking giac/giac.h usability... no
checking giac/giac.h presence... no
checking for giac/giac.h... no
configure: no suitable system package found for SPKG giac

mkoeppe · 2020-08-12T03:56:33Z

comment:12

archlinux-latest-standard (https://github.com/mkoeppe/sage/runs/969005637):

   TypeError: unable to start giac because the command 'giac --sage' failed: The command was not found or was not executable: giac.

mkoeppe · 2020-08-12T04:01:52Z

comment:13

Replying to @mkoeppe:

ubuntu-focal-standard (https://github.com/mkoeppe/sage/runs/969005184), debian-bullseye-standard: pexpect.exceptions.ExceptionPexpect: The command was not found or was not executable: giac.
So some package is still missing

debian has the giac executable in package xcas, which pulls in a lot of dependencies

mkoeppe · 2020-08-12T04:11:34Z

comment:14

Replying to @mkoeppe:

fedora-32-standard (https://github.com/mkoeppe/sage/runs/969005556):

... missing giac-devel

mkoeppe · 2020-08-12T04:31:12Z

comment:15

Replying to @mkoeppe:

archlinux-latest-standard (https://github.com/mkoeppe/sage/runs/969005637):

need package giac

sagetrac-git · 2020-08-12T04:48:16Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1923160`	`build/pkgs/giac/spkg-configure.m4: Test for giac executable`
`1016934`	`build/pkgs/giac/distros: Add missing packages`

sagetrac-git · 2020-08-12T04:48:16Z

Changed commit from 43ee06b to 1016934

mkoeppe · 2020-08-12T04:49:15Z

Dependencies: #29552

sagetrac-git · 2020-08-12T04:49:41Z

Changed commit from 1016934 to b4f2434

sagetrac-git · 2020-08-12T04:49:41Z

Branch pushed to git repo; I updated commit sha1. New commits:

`c076383`	`src/sage/interfaces/giac.py: Make new latex doctest more flexible`
`b4f2434`	`Merge branch 't/29552/upgrade_giac_to_1_5_0_87' into t/29541/spkg_configure_m4_for_giac`

mkoeppe · 2020-08-12T04:51:38Z

Changed reviewer from github.com/mkoeppe/sage/actions/runs/203238491 to https://github.com/mkoeppe/sage/actions/runs/205036006

mkoeppe · 2020-08-12T17:19:24Z

comment:20

This fixed ubuntu-focal-standard (https://github.com/mkoeppe/sage/runs/974323603); waiting for other runs to finish.

mkoeppe · 2020-08-15T21:28:04Z

comment:32

Replying to @mkoeppe:

archlinux-latest-standard (https://github.com/mkoeppe/sage/runs/974324005) now finds system giac 1.6.0.7 and reproduces the doctest errors reported in #29552 comment:2

ec95752 has changed it so it rejects giac >= 1.6, as can be seen in https://github.com/mkoeppe/sage/runs/985886420

The latest commit, 5efb0d7, fixes the doctest error.

Ready for review

mkoeppe · 2020-08-15T21:28:39Z

Changed reviewer from github.com/mkoeppe/sage/actions/runs/208891335, github.com/mkoeppe/sage/actions/runs/208891338, github.com/mkoeppe/sage/actions/runs/208891334 to github.com/mkoeppe/sage/actions/runs/208891335, github.com/mkoeppe/sage/actions/runs/208891338, github.com/mkoeppe/sage/actions/runs/208891334, ...

sagetrac-git · 2020-08-19T23:36:11Z

Changed commit from 5efb0d7 to f6e801e

sagetrac-git · 2020-08-19T23:36:11Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`0338556`	src/sage/libs/giac/giac.pyx: Update `_latex_` doctest
`798f6c2`	doctest fixes + `__len__` modification for giac 1.5.0.87 behavior with emptylist seq[]
`17bc2e4`	sage/libs/giac/giac.pyx: Make `_latex_` doctest more flexible
`7d25a4b`	`Merge branch 'public/29171' of git://trac.sagemath.org/sage into public/29171`
`2f528a1`	`put giac methods in a separate file with doctrings from giac's help`
`2e44aa6`	`remove optional giacpy_sage from multi_polynomial_ideal`
`db48d99`	`add a lazy import for libgiac`
`923f8f3`	`Merge tag '9.2.beta9' into t/29171/public/29171`
`911ddfb`	`GiacElement._latex_: Make array doctest more flexible`
`f6e801e`	`Merge branch 't/29171/public/29171' into t/29541/spkg_configure_m4_for_giac`

mkoeppe · 2020-08-19T23:36:34Z

Changed dependencies from #30127, #30339, #30345, #30144 to #30127, #30339, #30345, #30144, #29171

sagetrac-git · 2020-08-24T17:13:08Z

Changed commit from f6e801e to 4cf38df

sagetrac-git · 2020-08-24T17:13:08Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`ca43ddd`	`build/pkgs/giac/spkg-configure.m4: New`
`64e80ac`	`build/pkgs/giac/distros: Add debian, fedora, opensuse`
`ab410b9`	`build/pkgs/giac/spkg-configure.m4: Test for giac executable`
`83543d0`	`build/pkgs/giac/distros: Add missing packages`
`4cf38df`	`build/pkgs/giac/spkg-configure.m4: Reject giac >= 1.6`

mkoeppe · 2020-08-24T17:13:48Z

comment:37

Rebased, needs review

mkoeppe · 2020-08-24T17:13:48Z

Changed dependencies from #30127, #30339, #30345, #30144, #29171 to none

EmmanuelCharpentier · 2020-09-04T10:04:05Z

comment:39

On Debian testing, installing xcas, libgiac (and their dependencies) is not detected by ./configure. From config.log :

configure:35644: result: giac-1.5.0.87p0:                             does not support check for system package; will be installed as an SPKG

==>needs_work

dimpase · 2020-09-04T10:31:14Z

comment:40

I suppose you need libgiac-dev, not just libgiac.

https://packages.debian.org/sid/libgiac-dev

EmmanuelCharpentier · 2020-09-04T14:50:52Z

comment:41

Replying to @dimpase:

I suppose you need libgiac-dev, not just libgiac.

That's what I installed (and typoed when typing my answer... ;-).

So, still needs_work...

mkoeppe · 2020-09-04T15:26:04Z

comment:42

does not support check for system package

If you want to test this ticket, you need to use ./bootstrap

isuruf · 2020-09-10T17:25:54Z

comment:45

This looks good to me. Can you add giac to distros/conda.txt? You can set it to positive review afterwards.

isuruf · 2020-09-10T17:25:54Z

Changed reviewer from github.com/mkoeppe/sage/actions/runs/208891335, github.com/mkoeppe/sage/actions/runs/208891338, github.com/mkoeppe/sage/actions/runs/208891334, ... to Isuru Fernando

sagetrac-git · 2020-09-10T17:36:10Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0df15df`	`build/pkgs/giac/distros/conda.txt: New`

sagetrac-git · 2020-09-10T17:36:10Z

Changed commit from 4cf38df to 0df15df

mkoeppe · 2020-09-10T17:36:39Z

comment:47

Thanks!

vbraun · 2020-09-15T21:58:46Z

Changed branch from u/mkoeppe/spkg_configure_m4_for_giac to 0df15df

thierry-FreeBSD added this to the sage-9.1 milestone Apr 21, 2020

thierry-FreeBSD added c: build: configure labels Apr 21, 2020

mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 21, 2020

This comment has been minimized.

Sign in to view

EmmanuelCharpentier mannequin added s: needs work and removed s: needs review labels Sep 4, 2020

mkoeppe added s: needs review and removed s: needs work labels Sep 4, 2020

This comment has been minimized.

Sign in to view

mkoeppe added s: positive review and removed s: needs review labels Sep 10, 2020

vbraun removed the s: positive review label Sep 15, 2020

vbraun closed this as completed in dff7c61 Sep 15, 2020

embray mentioned this issue Jan 29, 2023

Meta-ticket: spkg-configure: Try to use as many system packages as possible #27330

Open

tobihan mentioned this issue Mar 30, 2021

Upgrade giac to 1.6.0-47 #30537

Closed

spkg-configure.m4 for giac #29541

spkg-configure.m4 for giac #29541

Comments

thierry-FreeBSD commented Apr 21, 2020

thierry-FreeBSD commented Apr 21, 2020

mkoeppe commented Apr 21, 2020

This comment has been minimized.

mkoeppe commented Aug 10, 2020

mkoeppe commented Aug 10, 2020

mkoeppe commented Aug 10, 2020

sagetrac-git mannequin commented Aug 10, 2020

sagetrac-git mannequin commented Aug 10, 2020

mkoeppe commented Aug 10, 2020

mkoeppe commented Aug 10, 2020

mkoeppe commented Aug 12, 2020

mkoeppe commented Aug 12, 2020

mkoeppe commented Aug 12, 2020

mkoeppe commented Aug 12, 2020

mkoeppe commented Aug 12, 2020

mkoeppe commented Aug 12, 2020

sagetrac-git mannequin commented Aug 12, 2020

sagetrac-git mannequin commented Aug 12, 2020

mkoeppe commented Aug 12, 2020

sagetrac-git mannequin commented Aug 12, 2020

sagetrac-git mannequin commented Aug 12, 2020

mkoeppe commented Aug 12, 2020

mkoeppe commented Aug 12, 2020

mkoeppe commented Aug 15, 2020

mkoeppe commented Aug 15, 2020

sagetrac-git mannequin commented Aug 19, 2020

sagetrac-git mannequin commented Aug 19, 2020

mkoeppe commented Aug 19, 2020

sagetrac-git mannequin commented Aug 24, 2020

sagetrac-git mannequin commented Aug 24, 2020

mkoeppe commented Aug 24, 2020

mkoeppe commented Aug 24, 2020

EmmanuelCharpentier mannequin commented Sep 4, 2020

dimpase commented Sep 4, 2020

EmmanuelCharpentier mannequin commented Sep 4, 2020

mkoeppe commented Sep 4, 2020

This comment has been minimized.

isuruf commented Sep 10, 2020

isuruf commented Sep 10, 2020

sagetrac-git mannequin commented Sep 10, 2020

sagetrac-git mannequin commented Sep 10, 2020

mkoeppe commented Sep 10, 2020

vbraun commented Sep 15, 2020