-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tox.ini / tox.yml: Move code for tagging/pushing docker images into tox.ini #30144
Comments
Reviewer: github.com/mkoeppe/sage/actions/runs/206174675, ... |
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Commit: |
Changed reviewer from github.com/mkoeppe/sage/actions/runs/206174675, ... to https://github.com/mkoeppe/sage/actions/runs/206465268 |
comment:4
This seems to work well (see for example https://github.com/mkoeppe/sage/runs/978681914); needs review |
Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/206465268 to https://github.com/mkoeppe/sage/actions/runs/206465268, ... |
comment:6
Let's get this in please. |
comment:7
Is this to worry about?
Otherwise looks fine. |
comment:8
This warning is not new, it used to appear in the "push docker images step". The "password" here is a token specifically created for the GitHub packages repository. I don't have a major concern about storing it in cleartext. See also docker/build-push-action#53, where the same issue is open for Docker's official actions. |
comment:9
I figured it was something like this. Just wanted to make sure. |
Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/206465268, ... to Jonathan Kliem |
comment:11
Thanks! |
Changed branch from u/mkoeppe/tox_ini___tox_yml__move_code_for_tagging_pushing_docker_images_into_tox_ini to |
Currently, there are reliability issues on GitHub Actions, builds time out or die for no apparent reason, and then no docker images are pushed.
We integrate this code into
tox.ini
so that the pushing happens after each of the steps defined byDOCKER_TARGETS
.Then one can pull an intermediate image and continue some tests locally.
CC: @kliem @dimpase
Component: porting
Author: Matthias Koeppe
Branch/Commit:
231b812
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/30144
The text was updated successfully, but these errors were encountered: