Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowance module: Add deployment instructions for contracts to README and remove outdated networks from hardhat configuration #494

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Allowance module: Add deployment instructions for contracts to README and remove outdated networks from hardhat configuration #494

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c34e9c4
"Add deployment instructions for contracts to README and update hardh…
mmv08 Sep 11, 2024
bf43371
Add deployment guidance to README with env variable requirements
mmv08 Sep 11, 2024
18f81c1
Remove deprecated networks from hardhat config
mmv08 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion modules/allowances/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,26 @@ pnpm test
```bash
pnpm i
pnpm build
```
```

## Deploying and verifying contracts

Specify all the necessary environment variables in `.env`, following the `.env.sample` file.

```bash
pnpm i
pnpm run deploy <network_name>
```

1. `network_name` is the name of the network you want to deploy to. It must be added to the hardhat config under `networks` beforehand.
2. If the hardhat plugin cannot figure out the etherscan API url for the network, you can add it manually to `tasks/deploy_verify.ts`.
Example:
```ts
await hre.run('etherscan-verify', {
forceLicense: true,
license: 'LGPL-3.0',
apiUrl: "https://api.gnosiscan.io"
})
```


8 changes: 0 additions & 8 deletions modules/allowances/hardhat.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,6 @@ const config: HardhatUserConfig = {
...sharedNetworkConfig,
url: `https://rpc.energyweb.org`,
mmv08 marked this conversation as resolved.
Show resolved Hide resolved
},
goerli: {
...sharedNetworkConfig,
url: `https://goerli.infura.io/v3/${INFURA_KEY}`,
},
mumbai: {
...sharedNetworkConfig,
url: `https://polygon-mumbai.infura.io/v3/${INFURA_KEY}`,
mmv08 marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -73,10 +69,6 @@ const config: HardhatUserConfig = {
...sharedNetworkConfig,
url: `https://polygon-mainnet.infura.io/v3/${INFURA_KEY}`,
},
volta: {
...sharedNetworkConfig,
url: `https://volta-rpc.energyweb.org`,
},
bsc: {
...sharedNetworkConfig,
url: `https://bsc-dataseed.binance.org/`,
Expand Down
Loading