Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowance module: Add deployment instructions for contracts to README and remove outdated networks from hardhat configuration #494

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Allowance module: Add deployment instructions for contracts to README and remove outdated networks from hardhat configuration #494

merged 3 commits into from
Sep 11, 2024

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Sep 11, 2024

  • Add deployment instructions for contracts to README
  • remove outdated networks from hardhat configuration

@mmv08 mmv08 requested a review from a team as a code owner September 11, 2024 12:37
@mmv08 mmv08 requested review from nlordell, akshay-ap and remedcu and removed request for a team September 11, 2024 12:37
@coveralls
Copy link

coveralls commented Sep 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10811959300

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.053%
Totals Coverage Status
Change from base Build 10811158948: 0.0%
Covered Lines: 100
Relevant Lines: 128
💛 - Coveralls

remedcu
remedcu approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@remedcu remedcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, rest LGTM 👍🏾

modules/allowances/hardhat.config.ts Outdated Show resolved Hide resolved
modules/allowances/hardhat.config.ts Outdated Show resolved Hide resolved
@mmv08 mmv08 merged commit a5aaf8e into main Sep 11, 2024
6 checks passed
@mmv08 mmv08 deleted the allowance-module/improve-docs branch September 11, 2024 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@remedcu remedcu remedcu approved these changes

@nlordell nlordell nlordell approved these changes

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap is a code owner automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmv08 @coveralls @nlordell @remedcu