Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _validateSignatures NatSpec Documentation #183

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fix _validateSignatures NatSpec Documentation #183

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36c90e6
Fix `_validateSignatures` NatSpec Documentation
nlordell Dec 6, 2023
8ed5b32
Details of packed validation data
nlordell Dec 6, 2023
43d9b6f
Use regular double quotes
nlordell Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 4337/contracts/Safe4337Module.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ contract Safe4337Module is IAccount, HandlerContext, CompatibilityFallbackHandle
}

/**
* @dev Validates that the user operation is correctly signed. Reverts if signatures are invalid.
* @dev Validates that the user operation is correctly signed and returns an ERC-4337 packed validation data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request (non-blocking): Can we reference what ERC-4337 packed validation data is and how it build? (i.e. a link to the relevant ERC section)

* @param userOp User operation struct.
* @return validationData An integer indicating the result of the validation.
*/
Expand Down