Fix _validateSignatures NatSpec Documentation
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7114266244
💛 - Coveralls |
rmeissner
approved these changes
Dec 6, 2023
4337/contracts/Safe4337Module.sol
Outdated
| @@ -167,7 +167,7 @@ contract Safe4337Module is IAccount, HandlerContext, CompatibilityFallbackHandle | |||
| } | |||
|
|
|||
| /** | |||
| * @dev Validates that the user operation is correctly signed. Reverts if signatures are invalid. | |||
| * @dev Validates that the user operation is correctly signed and returns an ERC-4337 packed validation data. | |||
There was a problem hiding this comment.
Minor request (non-blocking): Can we reference what ERC-4337 packed validation data is and how it build? (i.e. a link to the relevant ERC section)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the NatSpec documentation for the
_validateSignaturesinternal function. This fixes I6 from the Ackee audit v2.0.