Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku One Click deploy added #357

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

akhilgkrishnan
Copy link
Member

Notion card

Summary

The user can deploy the Miru app in Heroku by clicking on a single button.

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented May 4, 2022

Current Code Coverage Percent of this PR:

96.55 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/client.rb 92.5 %
/app/models/invoice.rb 95.83 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/services/application_service.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/checkout.rb 43.48 %

@rohitjoshixyz
Copy link
Contributor

@akhilgkrishnan Can you add a preview video to the PR? We can attach it to the readme.MD as well

Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhilgkrishnan akhilgkrishnan merged commit d23a515 into develop May 4, 2022
@akhilgkrishnan akhilgkrishnan deleted the heroku-oneclick-deploy branch May 4, 2022 08:04
Shruti-Apte added a commit that referenced this pull request May 6, 2022
* Basic UI for stripe connect

* Addition to basic UI

* Use react router for invoice page (#333)

* API for show invoice

* Remove show route

* Use react router for invoice page

* Address review comments

* Refactor and fix UI

* Avoid n+1 issue and use partials

* Fix rubocop failure

* Omit hash value

* Set init value as null

* added titleize property to name for capitalizing (#354)

* Invoice address spacing fixed (#355)

* Invoice address spacing fixed

* added commas

Co-authored-by: Shruti <shruti@saeloun.com>

* Bump version to 0.1.9

* Heroku One Click deploy added (#357)

* Fixes unit_amount for zero_decimal_currencies

* Moves unit_amout method to invoice model using Money gem.

* Adds test cases for unit_amount.

* Fixes typo

* Perform actions project details page (#358)

* Some actions added

* Some actions added

* Prepopulating client name on generate invoice page

* Resolved comments

Co-authored-by: Shruti <shruti@saeloun.com>

* Basic UI for stripe connect

* Addition to basic UI

* Updated designs

Co-authored-by: Shruti <shruti@saeloun.com>
Co-authored-by: Apoorv Mishra <apoorvmishra@saeloun.com>
Co-authored-by: Onkar Hasabe <104751221+onkar-saeloun@users.noreply.github.com>
Co-authored-by: Akhil G Krishnan <akhilgkrishnan4u@gmail.com>
Co-authored-by: Anas Ansari <anasansari157@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants