Invoice address spacing fixed #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shruti-Apte Please share loom video for this PR. |
Added Screenshot !! The address which is coming from backend is very small(somewhere in india) so added static address. |
Current Code Coverage Percent of this PR:96.55 %Files having coverage below 100%
|
|
@ajinkyaa Can you review it too? |
apoorv1316
approved these changes
May 4, 2022
Shruti-Apte
added a commit
that referenced
this pull request
May 6, 2022
* Basic UI for stripe connect * Addition to basic UI * Use react router for invoice page (#333) * API for show invoice * Remove show route * Use react router for invoice page * Address review comments * Refactor and fix UI * Avoid n+1 issue and use partials * Fix rubocop failure * Omit hash value * Set init value as null * added titleize property to name for capitalizing (#354) * Invoice address spacing fixed (#355) * Invoice address spacing fixed * added commas Co-authored-by: Shruti <shruti@saeloun.com> * Bump version to 0.1.9 * Heroku One Click deploy added (#357) * Fixes unit_amount for zero_decimal_currencies * Moves unit_amout method to invoice model using Money gem. * Adds test cases for unit_amount. * Fixes typo * Perform actions project details page (#358) * Some actions added * Some actions added * Prepopulating client name on generate invoice page * Resolved comments Co-authored-by: Shruti <shruti@saeloun.com> * Basic UI for stripe connect * Addition to basic UI * Updated designs Co-authored-by: Shruti <shruti@saeloun.com> Co-authored-by: Apoorv Mishra <apoorvmishra@saeloun.com> Co-authored-by: Onkar Hasabe <104751221+onkar-saeloun@users.noreply.github.com> Co-authored-by: Akhil G Krishnan <akhilgkrishnan4u@gmail.com> Co-authored-by: Anas Ansari <anasansari157@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion card
https://www.notion.so/saeloun/Fix-the-address-spacing-on-generate-invoice-page-5e8e0d92b6744eabb3c1b8dc0a1886a5
Summary
Fixed the spacing issue for generate invoice company address
Preview
Type of change
How Has This Been Tested?
Checklist: