Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrates Send Invoice button on invoices page #298

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Integrates Send Invoice button on invoices page #298

merged 2 commits into from
Apr 21, 2022

Conversation

shivamsinghchahar
Copy link
Contributor

@shivamsinghchahar shivamsinghchahar commented Apr 20, 2022 •
edited
Loading

Notion card

Fixes #288

Summary

Preview

https://www.loom.com/share/4fd2df830e434baabe8bad8398be55ae

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@shivamsinghchahar shivamsinghchahar self-assigned this Apr 20, 2022
@shivamsinghchahar shivamsinghchahar force-pushed the 288-integrate-send-invoices branch from 0743fc5 to fb0e29d Compare April 20, 2022 14:11
@github-actions
Copy link

Current Code Coverage Percent of this PR:

100.0 %

apoorv1316
apoorv1316 approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

murtaza-bagwala
murtaza-bagwala approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@murtaza-bagwala murtaza-bagwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gowsik-ragunath
gowsik-ragunath approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@gowsik-ragunath gowsik-ragunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but one minor comment.

@shivamsinghchahar shivamsinghchahar merged commit ab03f15 into develop Apr 21, 2022
@shivamsinghchahar shivamsinghchahar deleted the 288-integrate-send-invoices branch April 21, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gowsik-ragunath gowsik-ragunath gowsik-ragunath approved these changes

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@murtaza-bagwala murtaza-bagwala murtaza-bagwala approved these changes

@apoorv-mishra apoorv-mishra Awaiting requested review from apoorv-mishra

Assignees

@shivamsinghchahar shivamsinghchahar

Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to send invoice to client on email
4 participants
@shivamsinghchahar @murtaza-bagwala @apoorv1316 @gowsik-ragunath