Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual design added for client listing page #119

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

akhilgkrishnan
Copy link
Member

Pull Request Template

Description

Visual design added for client listing page

Fixes #96

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-119 February 8, 2022 06:30 Inactive
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Current Code Coverage Percent of this PR:

70.58 %

Files having coverage below 100%

Impacted Files Coverage
/config/application.rb 92.86 %
/config/routes.rb 94.74 %
/app/models/user.rb 83.33 %
/app/controllers/projects_controller.rb 50.0 %
/app/controllers/application_controller.rb 66.67 %
/app/helpers/application_helper.rb 40.0 %
/app/helpers/team_helper.rb 57.14 %
/app/helpers/users/registrations_helper.rb 41.67 %
/app/controllers/company_controller.rb 36.67 %
/app/controllers/root_controller.rb 33.33 %
/app/controllers/team_controller.rb 83.33 %
/app/controllers/users/passwords_controller.rb 41.67 %
/app/controllers/users/omniauth_callbacks_controller.rb 25.0 %
/app/controllers/users/sessions_controller.rb 25.0 %
/app/controllers/users/registrations_controller.rb 45.83 %
/app/controllers/users/invitations_controller.rb 63.64 %
/app/controllers/internal_api/v1/application_controller.rb 80.0 %
/app/controllers/internal_api/v1/clients_controller.rb 66.67 %

@vipulnsward vipulnsward temporarily deployed to miru-review-pr-119 February 8, 2022 07:38 Inactive
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@akhilgkrishnan akhilgkrishnan merged commit 89675e5 into develop Feb 8, 2022
@akhilgkrishnan akhilgkrishnan deleted the feature/96-add-visual-design-to-client-page branch February 8, 2022 08:01
@pr-triage pr-triage bot added the PR: merged label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clients page (2/X) - New Client button, Match visual design with Figma
3 participants