Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clients page (2/X) - New Client button, Match visual design with Figma #96

Closed
3 tasks
rohitjoshixyz opened this issue Jan 28, 2022 · 2 comments · Fixed by #119 or #125
Closed
3 tasks

Clients page (2/X) - New Client button, Match visual design with Figma #96

rohitjoshixyz opened this issue Jan 28, 2022 · 2 comments · Fixed by #119 or #125

Comments

@rohitjoshixyz
Copy link
Contributor

rohitjoshixyz commented Jan 28, 2022

PR 2: Follow visual design

  • Create a shared react component for New Client Button
  • Remove unnecessary columns from index table
  • Wrap table in container and match font as per design

Originally posted by @rohitjoshixyz in #77 (comment)

@supriya3105
Copy link
Contributor

@akhilgkrishnan The page doesn't match with the visual designs. The one you have created is for the employee role , but it should not have the edit, delete and add new client options. The client page for admin/owner had another component in the design. Please check the visual design in Figma.

Screenshot 2022-02-08 at 7 21 24 PM

@supriya3105 supriya3105 reopened this Feb 8, 2022
@akhilgkrishnan
Copy link
Member

akhilgkrishnan commented Feb 8, 2022

@supriya3105 for the graph it needs the time tracking feature. That's why I haven't added that component. Also, it requires some other features. That we can add in a separate issue.
For the edit, delete, and new client button access, I will update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants