Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #114

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Update README.md #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,16 @@ cp .env.example .env
the user is `root` and password is `password`, change the variable as
`DATABASE_URL="postgres://root:password@localhost/miru_web?encoding=utf8&pool=5&timeout=5000"`

10. Run `bin/rails db:create RAILS_ENV=development` to create the database
11. Run `bin/rails db:migrate RAILS_ENV=development` for migrations
12. Run app in local env
10. Update `APP_BASE_URL` in `.env` to `localhost:3000`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change this to some generic context. Because they need to update other env's as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for development. In fact, all instructions above are for development. What context do we need to set?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can say it generally, like

Update environment variables in .env

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was specifically for APP_BASE_URL which new devs get tricked on after confirming the email for first time registration since it redirects to the wrong URL if this env var is not correctly set(like what happened with @SiddharthShringi as discussed in standup the other day, happened with me too for the first time).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

11. Run `bin/rails db:create RAILS_ENV=development` to create the database
12. Run `bin/rails db:migrate RAILS_ENV=development` for migrations
13. Run app in local env

```
foreman start -f Procfile.dev
```

13. Navigate to [http://0.0.0.0:3000](http://0.0.0.0:3000)
14. Navigate to [http://0.0.0.0:3000](http://0.0.0.0:3000)

### To receive the emails in non-production apps.

Expand Down