-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #114
Update README.md #114
Conversation
5f57b67
to
79c8b42
Compare
Current Code Coverage Percent of this PR:70.58 %Files having coverage below 100%
|
10. Run `bin/rails db:create RAILS_ENV=development` to create the database | ||
11. Run `bin/rails db:migrate RAILS_ENV=development` for migrations | ||
12. Run app in local env | ||
10. Update `APP_BASE_URL` in `.env` to `localhost:3000` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change this to some generic context. Because they need to update other env's as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for development
. In fact, all instructions above are for development
. What context do we need to set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can say it generally, like
Update environment variables in .env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was specifically for APP_BASE_URL
which new devs get tricked on after confirming the email for first time registration since it redirects to the wrong URL if this env var is not correctly set(like what happened with @SiddharthShringi as discussed in standup the other day, happened with me too for the first time).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Pull Request Template
Description
Adds instruction for setting
APP_BASE_URL
in.env
on local.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: