[azure-search] Serialization fails due to Cannot map a recusive struc…

…ture (Azure#18542)

* Continue on a recursive structure walking

* Update Changelog

* Update sdk/search/search-documents/test/internal/serialization.spec.ts

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

* Update sdk/search/search-documents/test/internal/serialization.spec.ts

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

* Fix Typo

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>

sdk/search/search-documents/CHANGELOG.md

@@ -12,6 +12,10 @@
 - Renamed `SkillNames` property to `ResetSkillsOptions` (with a `SkillNames` property)
 - Renamed `ResetDocs` method to `ResetDocuments` in the SDK client.
 
+### Bugs Fixed
+
+- Fixed the issue with the presence of recursive structure while uploading documents. Please refer [#15656](https://github.com/Azure/azure-sdk-for-js/issues/15656) for further details.
+
 ### Features Added
 
 - Added properties `currentState` & `statusDetail` to the `IndexerExecutionResult` object.

sdk/search/search-documents/src/serialization.ts

@@ -36,7 +36,7 @@ function walk(start: unknown, mapper: (val: any) => any): any {
 
     if (typeof current.value === "object" && current.value !== null) {
       if (seenMarker.has(current.value)) {
-        throw new Error("Cannot map a recusive structure.");
+        continue;
       } else {
         seenMarker.set(current.value, true);
       }

sdk/search/search-documents/test/internal/serialization.spec.ts

@@ -14,9 +14,31 @@ describe("serialization.serialize", () => {
   });
 
   it("circular", () => {
-    const circluarInput: any = { a: null };
-    circluarInput.a = circluarInput;
-    assert.throws(() => serialize(circluarInput));
+    const circularInput: any = { a: null };
+    circularInput.a = circularInput;
+    const result = serialize(circularInput);
+    assert.deepEqual(circularInput, result);
+  });
+
+  it("recursive 1", () => {
+    const child = { hello: "world" };
+    const documents = [
+      { id: "1", children: [child] },
+      { id: "2", children: [child] }
+    ];
+    const result = serialize(documents);
+    assert.deepEqual(documents, result);
+  });
+
+  it("recursive 2", () => {
+    const child = { hello: Infinity, world: -Infinity, universe: NaN };
+    const documents = [
+      { id: "1", children: [child] },
+      { id: "2", children: [child] },
+      { id: "3", children: [child] }
+    ];
+    const result = serialize(documents);
+    assert.deepEqual(documents, result);
   });
 
   it("NaN", () => {
@@ -47,9 +69,31 @@ describe("serialization.deserialize", () => {
   });
 
   it("circular", () => {
-    const circluarInput: any = { a: null };
-    circluarInput.a = circluarInput;
-    assert.throws(() => deserialize(circluarInput));
+    const circularInput: any = { a: null };
+    circularInput.a = circularInput;
+    const result = deserialize(circularInput);
+    assert.deepEqual(circularInput, result);
+  });
+
+  it("recursive 1", () => {
+    const child = { hello: "world" };
+    const documents = [
+      { id: "1", children: [child] },
+      { id: "2", children: [child] }
+    ];
+    const result = deserialize(documents);
+    assert.deepEqual(documents, result);
+  });
+
+  it("recursive 2", () => {
+    const child = { hello: "INF", world: "-INF", universe: "NaN" };
+    const documents = [
+      { id: "1", children: [child] },
+      { id: "2", children: [child] },
+      { id: "3", children: [child] }
+    ];
+    const result = deserialize(documents);
+    assert.deepEqual(documents, result);
   });
 
   it("NaN", () => {