[azure-search] Serialization fails due to Cannot map a recusive structure #18542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirzec
approved these changes
Nov 4, 2021
sdk/search/search-documents/test/internal/serialization.spec.ts
Outdated
Show resolved
Hide resolved
| { id: "3", children: [child] } | ||
| ]; | ||
| const result = serialize(documents); | ||
| assert.deepEqual(documents, result); |
There was a problem hiding this comment.
wouldn't this fail because the result shape is {hello: 'INF', world: '-INF', universe: 'NaN'} instead of the number value after serialization?
sdk/search/search-documents/test/internal/serialization.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Nov 6, 2021
…ture (Azure#18542) * Continue on a recursive structure walking * Update Changelog * Update sdk/search/search-documents/test/internal/serialization.spec.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Update sdk/search/search-documents/test/internal/serialization.spec.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Fix Typo Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the issue reported at #15656. As discussed offline, we do not want to error out. Instead we can continue. I have also added the required test cases during the serialize/deserialize step.
@xirzec Please review and approve the PR.