-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon for hacklang #929
Conversation
I have just been told this icon was already added to |
Hmm, their latest release is still Edit: |
Maybe the complete Seti stuff should be updated? We have 59 'Seti & custom' at the moment, they have 168... Space-wise ... we start at |
microsoft/vscode@8023f20 this is the VSCode commit including the Hack icon from Seti UI, it looks like they just update the |
It seems like VSCode pins a certain commit of that repo any time they update, they don't depend on releases |
Ah, I found the font :-} https://github.com/jesseweed/seti-ui/tree/master/styles/_fonts/seti |
And that again reminds me, which I already mentioned somewhere else, that we should generate the |
@4e554c4c Maybe you are inclined to have a look at the PR above (931), that does away with the manual labor on glyph updates/inserts. |
@Finii I think I actually prefer the icon from the seti repo. How should I import it? |
Thank you. I would rather update all/most of Seti and add the 'new' Seti icons while being at that. Now with the autogen that is a breeze ;-) At some point in the future we need a |
ok, if that's coming in the near future this commit shouldn't be necessary |
Thank you; without your info about Seti I would not have come round to finally implement auto-rebuilding and thinking about updating Seti - at all. |
Description
Please explain the changes you made here.
Requirements / Checklist
What does this Pull Request (PR) do?
I downloaded the Hack icon from hacklang.org whose source is on github and is licensed CC BY 4.0. Then edited it to be monochrome/font friendly in inkscape, added it to
original-source.otf
in fontforge asU+E535
, and modifiedfont-patcher
and friends to support the changes.How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Similar PRs: #862 #833 #429
Closes: #904
Screenshots (if appropriate or helpful)