Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for hacklang #929

Closed
wants to merge 1 commit into from
Closed

Add icon for hacklang #929

wants to merge 1 commit into from

Conversation

4e554c4c
Copy link

Description

Please explain the changes you made here.

Requirements / Checklist

What does this Pull Request (PR) do?

I downloaded the Hack icon from hacklang.org whose source is on github and is licensed CC BY 4.0. Then edited it to be monochrome/font friendly in inkscape, added it to original-source.otf in fontforge as U+E535, and modified font-patcher and friends to support the changes.

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Similar PRs: #862 #833 #429

Closes: #904

Screenshots (if appropriate or helpful)

fontforge
neovim

@4e554c4c
Copy link
Author

I have just been told this icon was already added to seti-ui upstream: https://github.com/jesseweed/seti-ui/blob/master/icons/hacklang.svg
might want to use that icon instead

@Finii
Copy link
Collaborator

Finii commented Sep 15, 2022

Hmm, their latest release is still 0.8.3 0.8.1 from 2015.
Yet they talk about 1.0.0 in the readme.
Do you have a clue how they get that into atom?

Edit:
Obviously npm? Ah at least they have release tags, but no releases. Hmm.

@Finii
Copy link
Collaborator

Finii commented Sep 15, 2022

Maybe the complete Seti stuff should be updated?

We have 59 'Seti & custom' at the moment, they have 168...


Space-wise ... we start at E5FA and the next set starts at E700 -> 262 codepoints

@4e554c4c
Copy link
Author

microsoft/vscode@8023f20 this is the VSCode commit including the Hack icon from Seti UI, it looks like they just update the .woff font and give names to the codepoints

@4e554c4c
Copy link
Author

It seems like VSCode pins a certain commit of that repo any time they update, they don't depend on releases

@Finii
Copy link
Collaborator

Finii commented Sep 15, 2022

@Finii
Copy link
Collaborator

Finii commented Sep 15, 2022

Quick comparison

image

Notably the C and C++ icons look not very nice with new seti (personal opinion). Some other icons got nice updates.

@Finii
Copy link
Collaborator

Finii commented Sep 15, 2022

And that again reminds me, which I already mentioned somewhere else, that we should generate the original-source from the svgs in the release workflow.

@Finii
Copy link
Collaborator

Finii commented Sep 17, 2022

@4e554c4c Maybe you are inclined to have a look at the PR above (931), that does away with the manual labor on glyph updates/inserts.

@4e554c4c
Copy link
Author

@Finii I think I actually prefer the icon from the seti repo. How should I import it?

@Finii
Copy link
Collaborator

Finii commented Sep 19, 2022

@Finii I think I actually prefer the icon from the seti repo. How should I import it?

Thank you. I would rather update all/most of Seti and add the 'new' Seti icons while being at that. Now with the autogen that is a breeze ;-)

At some point in the future we need a v2.3.0-RC1 :-> so that you can already try the new icon.

@4e554c4c
Copy link
Author

ok, if that's coming in the near future this commit shouldn't be necessary
thank you :)

@4e554c4c 4e554c4c closed this Sep 19, 2022
@Finii
Copy link
Collaborator

Finii commented Sep 20, 2022

Thank you; without your info about Seti I would not have come round to finally implement auto-rebuilding and thinking about updating Seti - at all.

@Finii Finii mentioned this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hacklang icon
2 participants