-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Crystal icon #429
Merged
Merged
add Crystal icon #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanoasis
reviewed
Feb 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me so far, you put the new glyph exactly where I would've expected to see it.
This will go in the next release, was right in the middle of trying to wrap up 2.1.0
I will pull your branch down and do some quick checking
thanks. I think this is good to go for now! |
3 tasks
ryanoasis
pushed a commit
that referenced
this pull request
Sep 6, 2020
3 tasks
2 tasks
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
add Crystal icon
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add icon for the Crystal programming language (https://crystal-lang.org)
Requirements / Checklist
./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
./gotta-patch-em-all-font-patcher\!.sh Hermit
What does this Pull Request (PR) do?
Add icon for the Crystal programing language.
I used IcoMoon(https://icomoon.io/app) to convert the SVG file to the font and then converted it to OTF using FontForge. And add it to
original-source.otf
ase52f
. Also, I updatefont-patcher
to include new icon in patched fonts.How should this be manually tested?
Screenshots
Changes in
original-source.otf
Patched font:
Vim with patched font:
Let me know if I miss something.
Thanks!