Implement {join,leave}_multicast_v4_n #284
Conversation
|
This depends on rust-lang/libc#2625 for Android, Apple, and FreeBSD. |
There was a problem hiding this comment.
Can you include the libc update in the last commit to indicate it's required for this change.
If at all possible could you add a test of some kind, even if it just calls the function. I'm not sure if there is a way to get the value to check if its set correctly but that would be ideal of course, but not required.
Otherwise LGTM pending the libc changes.
|
Done! |
|
@Thomasdezeeuw what are next steps here? Should I remove this from apple,android,freebsd until the libc changes are included in a new release? |
|
Wait for rust-lang/libc#2635 to be published, usually doesn't take too long. |
Release v0.2.113 To include #2625. Unblocks rust-lang/socket2#284
|
@tamird libc 0.2.113 has been released, if you can update libc and squash that with the last commit this should be good to merge. |
These methods allow the local interface to be specified by its index or an address assigned to it. This is supported in Linux since 2.2, in FreeBSD since 13.0.0, and in macOS since 10.7. DragonFlyBSD: DragonFlyBSD/DragonFlyBSD@1926f58. OpenBSD: openbsd/src@c0ba2d2. Haiku, illumos, netbsd, redox, and solaris (and perhaps others) do not support ip_mreqn, so these functions are not available on those systems. Requires libc with rust-lang/libc@8cba30b, released in https://crates.io/crates/libc/0.2.113; the libc dependency is bumped to this version. Fixes #283.
|
Done, thanks. |
|
Green! |
|
Thanks @tamird, let me know if you want a release for this. |
|
Yes please! |
|
Looks like this breaks on linux s390x: https://github.com/PyO3/maturin/runs/4906697417?check_suite_focus=true |
|
@messense created rust-lang/libc#2643 to fix it. |
|
We should update the libc dependency to 0.2.114 and consider yanking 0.4.3. |
|
Release v0.4.4 and yanked v0.4.3. |
See individual commit messages (please don't squash on merge). @Thomasdezeeuw