Add ip_mreqn on more platforms
#2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
ip_mreqn on Apple and Androidip_mreqn on more platforms
|
The failure on freebsd 14 seems to be spurious, but I don't think I can cause it to retry. |
|
Just push a new commit |
|
You can do To trigger a CI rebuild. |
|
Is that necessary to get a review? |
|
The code looks fine, I'd just like CI to pass before merging. @bors r+ |
|
📌 Commit 163272b has been approved by |
bors
added a commit
that referenced
this pull request
Jan 17, 2022
Add `ip_mreqn` on more platforms See individual commits; please do not squash on merge. `@Thomasdezeeuw`
|
💔 Test failed - checks-actions |
Available since macOS 10.7. See https://developer.apple.com/documentation/kernel/ip_mreqn.
|
@Amanieu thanks, this is green now. |
Amanieu
reviewed
Jan 17, 2022
This was added in FreeBSD 13.0.0. See freebsd/freebsd-src@0dfc145a.
This was added to Android's libc (bionic) in 2013. See https://cs.android.com/android/_/android/platform/bionic/+/655a7c081f83b8351ed5f11a6c6accd9458293a8.
|
@bors r+ |
|
📌 Commit 037d741 has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Merged
bors
added a commit
that referenced
this pull request
Jan 20, 2022
Release v0.2.113 To include #2625. Unblocks rust-lang/socket2#284
bors
added a commit
that referenced
this pull request
Jan 24, 2022
Define ip_mreqn on OpenBSD Essentially an extension of #2625 Reference: https://man.openbsd.org/ip.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits; please do not squash on merge. @Thomasdezeeuw