Update Clippy #99406
Merged
Update Clippy #99406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure bors success depends on metadata_collection r? `@xFrednet` Currently bors runs the `metadata_collection` but merges before the run is finished, because the bors success dummy step didn't depend on it. This also makes sure that the `metadata_collection` test is run at the same time as the other base runs to not produce overhead. changelog: none
Uncomment test for rust-lang#8734 I believe the issue was an interaction between rustfix and `span_lint_and_sugg_for_edges`, so this would've been fixed by rust-lang#98261 (Thanks, `@WaffleLapkin!)` Closes rust-lang#8734 changelog: none
…ro, r=Manishearth Fix false-positive in `equatable_if_let` Was linting in external macros. I guess now that I know about rust-lang/rust-clippy#8694 it seems all kinda pointless until we resolve that. Nevertheless, it's an improvement. Fixes rust-lang#9066. changelog:`equatable_if_let` No longer lint on macros
Changelog for Rust 1.62 🦖 This special artifact was just discovered. The artifact details changes to something called Clippy. Presently and from the context, we were unable to determine what this is supposed to be. All we know, is that it seems to have an active community around it which supports it. The members sometimes use paper clips as a secret symbol for Clippy. I want to donate this artifact to the rust-lang organization, to have it displayed to the public. --- changelog: none
Fix broken hyperlink in documentation changelog: none The hyperlinks in [`is_digit_ascii_radix`](https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix)'s docs are broken. This PR fixes those.
Add `dev deprecate` to the development basics changelog: none
Add `cargo dev dogfood` changelog: Add `cargo dev dogfood` Part of rust-lang#5394
…p1995 Fix some links changelog: none
Fix direct `#[allow]` attributes in `let_unit_value` Fixes part of rust-lang#9080 Not sure why it doesn't work when the lint is emitted at the statement, but switching it to the local works fine changelog: Fix direct `#[allow]` attributes in [`let_unit_value`]
…on, r=Manishearth,flip1995 Correct lint version for `format_push_string` Closes rust-lang#9081 changelog: none IDK what else to say. Look I can draw an ascii penguin =D: ``` (^v^) <( )> w w ```
Fix broken link changelog: none
…ler-errors Factor out `hir::Node::Binding`
…y to a method receiver
|
r? @Manishearth |
3 tasks
|
@bors r+ p=10 |
|
⌛ Testing commit 7fab8a4 with merge e9b0bd014d715fa2ca13e528c355c79cae3d699d... |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
⌛ Testing commit 7fab8a4 with merge ec15a84f25dd908970f38a2fb6b2a38288220d12... |
|
I have no idea what happened here. Probably the re-approve tripped up bors? @bors retry |
|
Hmm, looks like there are no longs for the x86_64-gnu-tools runner which is probably the one that fails :/ |
|
Well, it passed this time: https://github.com/rust-lang-ci/rust/runs/7395020796?check_suite_focus=true |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (ed91732): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.