Convert rust_crate_map.cpp to Rust #9087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fhahn Sorry, but this already needs a rebase! |
|
Always good to see less C++! |
|
Thanks for the feedback, I've updated the patch & I hope I addressed all comments. |
| @@ -332,7 +332,7 @@ impl<K: Hash + Eq, V> HashMap<K, V> { | |||
| HashMap::with_capacity_and_keys(r.gen(), r.gen(), capacity) | |||
| } | |||
|
|
|||
| /// Create an empty HashMap with space for at least `capacity` | |||
| /// Create an empty HashMap with space for at least `capacity` | |||
|
This looks good to me, nice work! r=me with @huonw's fixes and a rebase. |
This function can be use to create HashSets before the tls is initialized.
|
@alexcrichton Everything should be fixed, I changed the HashSet initialization to use 0 for k0 and k1 and added a FIXME to use random numbers, when there is a way to get them from the OS-RNG directly |
|
@fhahn Can you run |
Conflicts: src/libstd/rt/logging.rs
|
@catamorphism Done, all style errors should be fixed. |
bors
added a commit
that referenced
this pull request
Sep 13, 2013
This patch converts the rust_crate_map.cpp to Rust as mentioned at the end of #8880.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 18, 2022
Fix broken link changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch converts the rust_crate_map.cpp to Rust as mentioned at the end of #8880.