Modernize time::tm and make it serializable #4046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to Tm and Tm_. Not entirely clear what the best way to do this is. Right now we persist the entire struct which seems to be both portable and exactly round-trippable.
This avoids rust-lang#4044 by not using the enum wrapper, and turning Tm_ directly into a struct. Along the way it modernizes the codebase to eliminate no-implicit-copies warnings.
|
Thanks! Merged. |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Dec 8, 2024
Fill out windows io error mapping table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of @jesse99's #4041 pull request. It avoids #4044 by getting rid of the wrapper
Tmenum, and turningTm_directly into a struct.