Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad auto_serialize code #4044

Closed
jesse99 opened this issue Nov 27, 2012 · 0 comments
Closed

Bad auto_serialize code #4044

jesse99 opened this issue Nov 27, 2012 · 0 comments

Comments

@jesse99
Copy link
Contributor

jesse99 commented Nov 27, 2012

As part of #4041 tried to get Tm auto serializing, but was getting

/Volumes/SSD/rust/src/libstd/time.rs:138:8: 138:11 error: binding `__v0` should use ref or copy mode
/Volumes/SSD/rust/src/libstd/time.rs:138     Tm_(Tm_)
                                                 ^~~
/Volumes/SSD/rust/src/libstd/time.rs:138:8: 138:11 error: binding `__v0` should use ref or copy mode
/Volumes/SSD/rust/src/libstd/time.rs:138     Tm_(Tm_)
                                                 ^~~
error: aborting due to 2 previous errors
erickt added a commit to erickt/rust that referenced this issue Nov 27, 2012
@erickt
libstd: turn time::Tm and time::Timespec into structs
e8741d9 
This avoids rust-lang#4044 by not using the enum wrapper, and turning Tm_
directly into a struct. Along the way it modernizes the codebase
to eliminate no-implicit-copies warnings.
@erickt erickt mentioned this issue Nov 27, 2012
Merged
erickt added a commit to erickt/rust that referenced this issue Nov 27, 2012
@erickt
libstd: turn time::Tm and time::Timespec into structs
cd6300e 
This avoids rust-lang#4044 by not using the enum wrapper, and turning Tm_
directly into a struct. Along the way it modernizes the codebase
to eliminate no-implicit-copies warnings.
@erickt erickt closed this as completed in 32763ca Nov 28, 2012
RalfJung added a commit to RalfJung/rust that referenced this issue Nov 21, 2024
@RalfJung
Merge pull request rust-lang#4044 from RalfJung/rustup
12ac750 
Rustup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erickt @jesse99