Avoid some pat_to_string calls.
#37014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
approved these changes
Oct 7, 2016
|
You only need to call |
`ty_of_method_or_bare_fn` currently calls `pat_to_string` even when it doesn't need to. Fixing this avoids hundreds of large allocations (e.g. 171,600 bytes, in `mk_printer`) in several of the rustc-benchmarks.
7710798 to
e5ffade
Compare
|
I moved the r? @arielb1 |
|
@bors r+ |
|
📌 Commit e5ffade has been approved by |
bors
added a commit
that referenced
this pull request
Oct 8, 2016
Avoid some `pat_to_string` calls. `ty_of_method_or_bare_fn` currently calls `pat_to_string` even when it doesn't need to. Fixing this avoids hundreds of large allocations (e.g. 171,600 bytes, in `mk_printer`) in several of rustc-benchmarks.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 6, 2016
@nnethercote added the optimization that find_implied_output_region takes a closure as an optimization in rust-lang#37014, but passing an iterator is simpler, and more ergonomic for callers.
bors
added a commit
that referenced
this pull request
Dec 6, 2016
Simplify calling find_implied_output_region. @nnethercote added the optimization that find_implied_output_region takes a closure as an optimization in #37014, but passing an iterator is simpler, and more ergonomic for callers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ty_of_method_or_bare_fncurrently callspat_to_stringeven when itdoesn't need to. Fixing this avoids hundreds of large allocations (e.g.
171,600 bytes, in
mk_printer) in several of rustc-benchmarks.